Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/50110 )
Change subject: security/vboot: Add config for GBB_FLAG_ENABLE_UDC ......................................................................
security/vboot: Add config for GBB_FLAG_ENABLE_UDC
This change adds the missing `GBB_FLAG_ENABLE_UDC` as a config in vboot/Kconfig (just like the other GBB flags) and uses its value to configure GBB_FLAGS Makefile variable. This is done to allow the mainboard to configure GBB flags by selecting appropriate configs in Kconfig.
Signed-off-by: Eric Lai ericr_lai@compal.corp-partner.google.com Change-Id: I6b397713d643cf9461294e6928596dc847ace6bd Reviewed-on: https://review.coreboot.org/c/coreboot/+/50110 Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/Kconfig M src/security/vboot/Makefile.inc 2 files changed, 5 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/src/security/vboot/Kconfig b/src/security/vboot/Kconfig index e774478..e202333 100644 --- a/src/security/vboot/Kconfig +++ b/src/security/vboot/Kconfig @@ -338,6 +338,10 @@ bool "Disable Firmware Management Parameters (FWMP)" default n
+config GBB_FLAG_ENABLE_UDC + bool "Enable USB Device Controller" + default n + endmenu # GBB
menu "Vboot Keys" diff --git a/src/security/vboot/Makefile.inc b/src/security/vboot/Makefile.inc index 4cf8090..1703748 100644 --- a/src/security/vboot/Makefile.inc +++ b/src/security/vboot/Makefile.inc @@ -226,6 +226,7 @@ $(call bool-to-mask,$(CONFIG_GBB_FLAG_DISABLE_LID_SHUTDOWN),0x1000) \ $(call bool-to-mask,$(CONFIG_GBB_FLAG_FORCE_MANUAL_RECOVERY),0x4000) \ $(call bool-to-mask,$(CONFIG_GBB_FLAG_DISABLE_FWMP),0x8000) \ + $(call bool-to-mask,$(CONFIG_GBB_FLAG_ENABLE_UDC),0x10000) \ )
ifneq ($(CONFIG_GBB_BMPFV_FILE),)
-
Patrick Georgi (Code Review)