[S] Change in coreboot[master]: soc/intel/common/tcss: Configure USB-C ports with attached devices

[Martin L Roth (Code Review)]

Attention is currently required from: Jakub Czapiga, John Su, John Zhao, Kapil Porwal, Matt DeVillier, Sean Rhodes, Subrata Banik.

Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72909?usp=email )

Change subject: soc/intel/common/tcss: Configure USB-C ports with attached devices
......................................................................

Patch Set 8: Code-Review+2

(1 comment)

File src/soc/intel/common/block/tcss/tcss.c:

https://review.coreboot.org/c/coreboot/+/72909/comment/a0eecd01_45bbdefc :
PS8, Line 363: BIOS_ERR
Is ERR really the appropriate level here? I'd consider BIOS_WARNING.

It's probably not a big deal since we're using BIOS_ERR in the send_pmc_connect_request_routine, so I'm going to go ahead and merge it, but we should probably look at the log levels throughout coreboot.

BIOS_ERR:
 * Log level for when the system has experienced an issue that may not preclude
 * a successful boot. To be used when coreboot execution may still succeed,
 * but the error places some non-essential portion of the machine in a broken
 * state that will be noticed downstream.
 *
 * Example - Payload could still load, but will be missing access to integral
 * components such as drives.

BIOS_WARNING:
 * Log level for when the system has noticed an issue that most likely will
 * not preclude a successful boot. To be used when something is wrong, and
 * would likely be noticed by an end user.
 *
 * Example - Bad ME firmware, bad microcode, mis-clocked CPU