Change in coreboot[master]: mb/amd/mandolin: Drop SPD eeproms in devicetree

[Kyösti Mälkki (Code Review)]

Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/43046 )

Change subject: mb/amd/mandolin: Drop SPD eeproms in devicetree
......................................................................

mb/amd/mandolin: Drop SPD eeproms in devicetree

Even with previous platforms, these entries were not
utilised for raminit.

Change-Id: I9a9a1a292bad8c4c89cbacb826c80f4098cae00f
Signed-off-by: Kyösti Mälkki 
---
M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
1 file changed, 1 insertion(+), 6 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/46/43046/1

diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
index 495961f..97022c5 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
@@ -62,12 +62,7 @@
    		device pci 0.1 off end # integrated Ethernet MAC
    		device pci 0.2 off end # integrated Ethernet MAC
    	end
-		device pci 14.0 on     # SM
-			chip drivers/generic/generic # dimm 0-0-0
-				device i2c 50 on end
-				device i2c 51 on end
-			end
-		end # SM
+		device pci 14.0 on  end # SM
    	device pci 14.3 on  # - D14F3 bridge
    		chip superio/smsc/sio1036 # optional debug card
    		end

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43046 )

Change subject: mb/amd/mandolin: Drop SPD eeproms in devicetree
......................................................................

Patch Set 1: Code-Review+1

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43046 )

Change subject: mb/amd/mandolin: Drop SPD eeproms in devicetree
......................................................................

Patch Set 1:

Those aren't used for RAM init; will run a boot test on Mandolin on Monday

[Christian Walter (Code Review)]

Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43046 )

Change subject: mb/amd/mandolin: Drop SPD eeproms in devicetree
......................................................................

Patch Set 1: Code-Review+1

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43046 )

Change subject: mb/amd/mandolin: Drop SPD eeproms in devicetree
......................................................................

Patch Set 1: Code-Review+2

[Felix Held (Code Review)]

Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/43046 )

Change subject: mb/amd/mandolin: Drop SPD eeproms in devicetree
......................................................................

mb/amd/mandolin: Drop SPD eeproms in devicetree

Even with previous platforms, these entries were not
utilised for raminit.

Change-Id: I9a9a1a292bad8c4c89cbacb826c80f4098cae00f
Signed-off-by: Kyösti Mälkki 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43046
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Christian Walter 
Reviewed-by: Felix Held 
---
M src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
1 file changed, 1 insertion(+), 6 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Felix Held: Looks good to me, approved
  Christian Walter: Looks good to me, but someone else must approve

diff --git a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
index 495961f..97022c5 100644
--- a/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
+++ b/src/mainboard/amd/mandolin/variants/mandolin/devicetree.cb
@@ -62,12 +62,7 @@
    		device pci 0.1 off end # integrated Ethernet MAC
    		device pci 0.2 off end # integrated Ethernet MAC
    	end
-		device pci 14.0 on     # SM
-			chip drivers/generic/generic # dimm 0-0-0
-				device i2c 50 on end
-				device i2c 51 on end
-			end
-		end # SM
+		device pci 14.0 on  end # SM
    	device pci 14.3 on  # - D14F3 bridge
    		chip superio/smsc/sio1036 # optional debug card
    		end

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43046 )

Change subject: mb/amd/mandolin: Drop SPD eeproms in devicetree
......................................................................

Patch Set 2:

also applied the same change to CB:42786