Change in coreboot[master]: commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support
Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37052 )
Change subject: commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support
Change-Id: Idfbc0cf24000c361c9272fe0f61797de999c9277 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/commonlib/storage/pci_sdhci.c 1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37052/1
diff --git a/src/commonlib/storage/pci_sdhci.c b/src/commonlib/storage/pci_sdhci.c index abc093f..0f9c780 100644 --- a/src/commonlib/storage/pci_sdhci.c +++ b/src/commonlib/storage/pci_sdhci.c @@ -12,7 +12,6 @@ * GNU General Public License for more details. */
-#include <arch/early_variables.h> #include <commonlib/sdhci.h> #include <device/pci.h> #include <device/pci_ops.h> @@ -32,22 +31,22 @@
struct sd_mmc_ctrlr *new_mem_sdhci_controller(void *ioaddr) { - static bool sdhci_init_done CAR_GLOBAL; - static struct sdhci_ctrlr sdhci_ctrlr CAR_GLOBAL; + static bool sdhci_init_done; + static struct sdhci_ctrlr sdhci_ctrlr;
- if (car_get_var(sdhci_init_done) == true) { + if (sdhci_init_done) == true { sdhc_error("Error: SDHCI is already initialized.\n"); return NULL; }
- if (sdhci_controller_init(car_get_var_ptr(&sdhci_ctrlr), ioaddr)) { + if (sdhci_controller_init(&sdhci_ctrlr, ioaddr)) { sdhc_error("Error: SDHCI initialization failed.\n"); return NULL; }
- car_set_var(sdhci_init_done, true); + sdhci_init_done = true;
- return car_get_var_ptr(&sdhci_ctrlr.sd_mmc_ctrlr); + return &sdhci_ctrlr.sd_mmc_ctrlr; }
struct sd_mmc_ctrlr *new_pci_sdhci_controller(pci_devfn_t dev)
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37052 )
Change subject: commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/37052/1/src/commonlib/storage/pci_s... File src/commonlib/storage/pci_sdhci.c:
https://review.coreboot.org/c/coreboot/+/37052/1/src/commonlib/storage/pci_s... PS1, Line 37: if (sdhci_init_done) == true { trailing statements should be on next line
Arthur Heymans has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/37052 )
Change subject: commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support
Change-Id: Idfbc0cf24000c361c9272fe0f61797de999c9277 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/commonlib/storage/pci_sdhci.c 1 file changed, 6 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/52/37052/2
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37052 )
Change subject: commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 7: Code-Review+1
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37052 )
Change subject: commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
Patch Set 7: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/37052 )
Change subject: commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support ......................................................................
commonlib/storage/pci_sdhci.c: Drop CAR_GLOBAL_MIGRATION support
Change-Id: Idfbc0cf24000c361c9272fe0f61797de999c9277 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/37052 Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Patrick Georgi pgeorgi@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/commonlib/storage/pci_sdhci.c 1 file changed, 6 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/src/commonlib/storage/pci_sdhci.c b/src/commonlib/storage/pci_sdhci.c index abc093f..380f2db 100644 --- a/src/commonlib/storage/pci_sdhci.c +++ b/src/commonlib/storage/pci_sdhci.c @@ -12,7 +12,6 @@ * GNU General Public License for more details. */
-#include <arch/early_variables.h> #include <commonlib/sdhci.h> #include <device/pci.h> #include <device/pci_ops.h> @@ -32,22 +31,22 @@
struct sd_mmc_ctrlr *new_mem_sdhci_controller(void *ioaddr) { - static bool sdhci_init_done CAR_GLOBAL; - static struct sdhci_ctrlr sdhci_ctrlr CAR_GLOBAL; + static bool sdhci_init_done; + static struct sdhci_ctrlr sdhci_ctrlr;
- if (car_get_var(sdhci_init_done) == true) { + if (sdhci_init_done == true) { sdhc_error("Error: SDHCI is already initialized.\n"); return NULL; }
- if (sdhci_controller_init(car_get_var_ptr(&sdhci_ctrlr), ioaddr)) { + if (sdhci_controller_init(&sdhci_ctrlr, ioaddr)) { sdhc_error("Error: SDHCI initialization failed.\n"); return NULL; }
- car_set_var(sdhci_init_done, true); + sdhci_init_done = true;
- return car_get_var_ptr(&sdhci_ctrlr.sd_mmc_ctrlr); + return &sdhci_ctrlr.sd_mmc_ctrlr; }
struct sd_mmc_ctrlr *new_pci_sdhci_controller(pci_devfn_t dev)
-
Arthur Heymans (Code Review) -
build bot (Jenkins) (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)