Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19724 )
Change subject: soc/amd/stoneyridge: Add northbridge support ......................................................................
Patch Set 2:
(2 comments)
Same complaint as "CPU files" patch regarding BiosCallOuts.h.
https://review.coreboot.org/#/c/19724/2/src/soc/amd/common/agesawrapper.c File src/soc/amd/common/agesawrapper.c:
PS2, Line 23: #include <northbridge/amd/pi/agesawrapper.h> : #include <northbridge/amd/pi/BiosCallOuts.h> Missed these two.
#include <agesawrapper.h> #include <soc/amd/common/BiosCallOuts.h>
https://review.coreboot.org/#/c/19724/2/src/soc/amd/stoneyridge/dimmSpd.c File src/soc/amd/stoneyridge/dimmSpd.c:
PS2, Line 21: #include "Porting.h" : #include "AGESA.h" : #include "amdlib.h" : #include "chip.h" : #include "northbridge/amd/pi/dimmSpd.h" #include <Porting.h> #include <AGESA.h> #include <amdlib.h> #include <dimmSpd.h> #include "chip.h"