Attention is currently required from: Anastasios Koutian, Patrick Rudolph.
Angel Pons has posted comments on this change by Anastasios Koutian. ( https://review.coreboot.org/c/coreboot/+/83269?usp=email )
Change subject: cpu/intel/model_206ax: Allow PL1/PL2 configuration ......................................................................
Patch Set 1:
(2 comments)
File src/cpu/intel/model_206ax/chip.h:
https://review.coreboot.org/c/coreboot/+/83269/comment/4bfe339f_4309048c?usp... : PS1, Line 46: int pl1; /* Long-term power limit*/ : int pl2; /* Short-term power limit*/
These are in microwatts. Agree that units should be made clear. […]
Huh, that's a pretty small unit. Out of curiosity, any reason to use microwatts instead of watts?
In any case, I'd suggest something like this: ```suggestion unsigned int pl1_uw; /* Long-term power limit, in microwatts */ unsigned int pl2_uw; /* Short-term power limit, in microwatts */ ```
File src/northbridge/intel/sandybridge/northbridge.c:
https://review.coreboot.org/c/coreboot/+/83269/comment/efc11a45_c815f9c4?usp... : PS1, Line 354: 28
Yes, although it should be made clear that the lowest of the two power limits would apply when both […]
Actually, this is the time parameter, Tau. I'm not sure if there's any benefit to configuring it, so I wouldn't worry.