[M] Change in coreboot[master]: Documentation/mb/starlabs: De-duplicate the building instructions
Felix Held has submitted this change. ( https://review.coreboot.org/c/coreboot/+/68585 )
(
14 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: Documentation/mb/starlabs: De-duplicate the building instructions ......................................................................
Documentation/mb/starlabs: De-duplicate the building instructions
Signed-off-by: Sean Rhodes sean@starlabs.systems Change-Id: I20301b3041a62eb416ed61a84544ec4e5cc66c1e Reviewed-on: https://review.coreboot.org/c/coreboot/+/68585 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- A Documentation/mainboard/starlabs/common/building.md M Documentation/mainboard/starlabs/labtop_cml.md M Documentation/mainboard/starlabs/labtop_kbl.md M Documentation/mainboard/starlabs/lite_glk.md M Documentation/mainboard/starlabs/lite_glkr.md M Documentation/mainboard/starlabs/starbook_adl.md M Documentation/mainboard/starlabs/starbook_tgl.md 7 files changed, 50 insertions(+), 103 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/Documentation/mainboard/starlabs/common/building.md b/Documentation/mainboard/starlabs/common/building.md new file mode 100644 index 0000000..3b9b568 --- /dev/null +++ b/Documentation/mainboard/starlabs/common/building.md @@ -0,0 +1,30 @@ +## Building coreboot + +### Preliminaries + +Prior to building coreboot the following files are required: + +#### StarBook series: +* Intel Flash Descriptor file (descriptor.bin) +* Intel Management Engine firmware (me.bin) +* ITE Embedded Controller firmware (ec.bin) + +#### StarLite series: +* Intel Flash Descriptor file (descriptor.bin) +* IFWI Image (ifwi.rom) + +The files listed below are optional: +- Splash screen image in Windows 3.1 BMP format (Logo.bmp) + +These files exist in the correct location in the [StarLabsLtd/blobs](https://github.com/StarLabsLtd/blobs) repo on GitHub which is used in place of the standard 3rdparty/blobs repo. + +### Build + +The following commands will build a working image, where the last two words represent the +series and processor i.e. `lite_glkr`: + +```bash +make distclean +make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_starbook_adl +make +``` diff --git a/Documentation/mainboard/starlabs/labtop_cml.md b/Documentation/mainboard/starlabs/labtop_cml.md index 2f70173..0a493f8 100644 --- a/Documentation/mainboard/starlabs/labtop_cml.md +++ b/Documentation/mainboard/starlabs/labtop_cml.md @@ -41,27 +41,7 @@
## Building coreboot
-### Preliminaries - -Prior to building coreboot the following files are required: -* Intel Flash Descriptor file (descriptor.bin) -* Intel Management Engine firmware (me.bin) -* ITE Embedded Controller firmware (ec.bin) - -The files listed below are optional: -- Splash screen image in Windows 3.1 BMP format (Logo.bmp) - -These files exist in the correct location in the StarLabsLtd/blobs repo on GitHub which is used in place of the standard 3rdparty/blobs repo. - -### Build - -The following commands will build a working image: - -```bash -make distclean -make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_labtop_cml -make -``` +Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_labtop_cml` as config file.
## Flashing coreboot
diff --git a/Documentation/mainboard/starlabs/labtop_kbl.md b/Documentation/mainboard/starlabs/labtop_kbl.md index 35ff5e3..f68b95e 100644 --- a/Documentation/mainboard/starlabs/labtop_kbl.md +++ b/Documentation/mainboard/starlabs/labtop_kbl.md @@ -38,26 +38,7 @@
## Building coreboot
-### Preliminaries - -Prior to building coreboot the following files are required: -* Intel Flash Descriptor file (descriptor.bin) -* Intel Management Engine firmware (me.bin) - -The below are optional: -- Splash screen image in Windows 3.1 BMP format (Logo.bmp) - -These files exist in the correct location in the StarLabsLtd/blobs repo on GitHub which is used in place of the standard 3rdparty/blobs repo. - -### Build - -The following commands will build a working image: - -```bash -make distclean -make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_labtop_kbl -make -``` +Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_labtop_kbl` as config file.
## Flashing coreboot
diff --git a/Documentation/mainboard/starlabs/lite_glk.md b/Documentation/mainboard/starlabs/lite_glk.md index 2b475e5..6294b45 100644 --- a/Documentation/mainboard/starlabs/lite_glk.md +++ b/Documentation/mainboard/starlabs/lite_glk.md @@ -37,27 +37,7 @@
## Building coreboot
-### Preliminaries - -Prior to building coreboot the following files are required: -* Intel Flash Descriptor file (descriptor.bin) -* Intel Management Engine firmware (me.bin) -* ITE Embedded Controller firmware (ec.bin) - -The files listed below are optional: -- Splash screen image in Windows 3.1 BMP format (Logo.bmp) - -These files exist in the correct location in the StarLabsLtd/blobs repo on GitHub which is used in place of the standard 3rdparty/blobs repo. - -### Build - -The following commands will build a working image: - -```bash -make distclean -make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_lite_glk -make -``` +Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_lite_glk` as config file.
## Flashing coreboot
diff --git a/Documentation/mainboard/starlabs/lite_glkr.md b/Documentation/mainboard/starlabs/lite_glkr.md index 52e3898..57749d9 100644 --- a/Documentation/mainboard/starlabs/lite_glkr.md +++ b/Documentation/mainboard/starlabs/lite_glkr.md @@ -37,26 +37,7 @@
## Building coreboot
-### Preliminaries - -Prior to building coreboot the following files are required: -* Intel Flash Descriptor file (descriptor.bin) -* IFWI Image (ifwi.rom) - -The files listed below are optional: -- Splash screen image in Windows 3.1 BMP format (Logo.bmp) - -These files exist in the correct location in the StarLabsLtd/blobs repo on GitHub which is used in place of the standard 3rdparty/blobs repo. - -### Build - -The following commands will build a working image: - -```bash -make distclean -make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_lite_glkr -make -``` +Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_lite_glkr` as config file.
## Flashing coreboot
diff --git a/Documentation/mainboard/starlabs/starbook_adl.md b/Documentation/mainboard/starlabs/starbook_adl.md index 8e1a7c2..814dfc6 100644 --- a/Documentation/mainboard/starlabs/starbook_adl.md +++ b/Documentation/mainboard/starlabs/starbook_adl.md @@ -40,6 +40,8 @@
## Building coreboot
+Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_starbook_adl` as config file. + ### Preliminaries
Prior to building coreboot the following files are required: diff --git a/Documentation/mainboard/starlabs/starbook_tgl.md b/Documentation/mainboard/starlabs/starbook_tgl.md index fe12edc..5992d6c 100644 --- a/Documentation/mainboard/starlabs/starbook_tgl.md +++ b/Documentation/mainboard/starlabs/starbook_tgl.md @@ -40,27 +40,7 @@
## Building coreboot
-### Preliminaries - -Prior to building coreboot the following files are required: -* Intel Flash Descriptor file (descriptor.bin) -* Intel Management Engine firmware (me.bin) -* ITE Embedded Controller firmware (ec.bin) - -The files listed below are optional: -- Splash screen image in Windows 3.1 BMP format (Logo.bmp) - -These files exist in the correct location in the StarLabsLtd/blobs repo on GitHub which is used in place of the standard 3rdparty/blobs repo. - -### Build - -The following commands will build a working image: - -```bash -make distclean -make defconfig KBUILD_DEFCONFIG=configs/config.starlabs_starbook_tgl -make -``` +Please follow the [Star Labs build instructions](../common/building.md) to build coreboot, using `config.starlabs_starbook_tgl` as config file.
## Flashing coreboot
-
Felix Held (Code Review)