Change in coreboot[master]: mb/google/brya: Create primus variant - coreboot-gerrit

27 May 2021


      Attention is currently required from: Paul Menzel, Scott Chao.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/54941 )
Change subject: mb/google/brya: Create primus variant
......................................................................
Patch Set 4:
(1 comment)
File src/mainboard/google/brya/variants/primus/memory/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/54941/comment/4415648b_db77e8c0 
PS2, Line 5: placeholder.spd.hex
...
`HAVE_SPD_IN_CBFS is set but SPD_SOURCES is empty` […]
You would need one in adl/spd too, right?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/54941
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I441e4f0ebea3b9db813e321d32ca990e9c51c668
Gerrit-Change-Number: 54941
Gerrit-PatchSet: 4
Gerrit-Owner: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Casper Chang casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Malik Hsu malik_hsu@wistron.corp-partner.google.com
Gerrit-CC: Mark Hsieh mark_hsieh@wistron.corp-partner.google.com
Gerrit-CC: Nick Chen nick_xr_chen@wistron.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-Comment-Date: Thu, 27 May 2021 18:20:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Comment-In-Reply-To: Scott Chao scott_chao@wistron.corp-partner.google.com
Gerrit-MessageType: comment