Attention is currently required from: Tim Wawrzynczak. Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57540 )
Change subject: mb/google/brya: Fix brya0 WWAN poweron sequencing ......................................................................
Patch Set 5:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/57540/comment/5da1107c_fc58d215 PS5, Line 11: because the modem requires a ~10 seconds : initialization phase before it can be used Then the 300 ms difference used by coreboot shouldn’t make a difference then for the added complexity?
File src/mainboard/google/brya/variants/baseboard/brya/gpio.c:
https://review.coreboot.org/c/coreboot/+/57540/comment/87f1b913_5010a5fc PS5, Line 208: /* E0 : SATAXPCIE0 ==> WWAN_PERST_L : * NB. Driven high here so that it is sequenced after WWAN_RST_L; : * a PERST# signal would be reset by PLRST#, but it will be explicitly : * programmed during a power-down sequence. */ Please use the recommended style for multiline comments [1].
[1]: https://doc.coreboot.org/contributing/coding_style.html#commenting