Change in coreboot[master]: b/google/volteer/variant/lindar: change speaker smart amplifier to AL...
Stanley Wu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
Lindar change amp to ALC1011 adding ALC1011 amp acpi info into devicetree
BUG=b:171771736 BRANCH=None TEST=build and verify ALC1011 can be recognized.
Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4 Signed-off-by: stanley.wu stanley1.wu@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb 4 files changed, 20 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/47009/1
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index f59d82b..268bd69 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -22,6 +22,8 @@ bool "-> Lindar" select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU + select CHROMEOS_DSM_CALIB + select DRIVERS_I2C_RT1011
config BOARD_GOOGLE_MALEFOR bool "-> Malefor" diff --git a/src/mainboard/google/volteer/fw_config.c b/src/mainboard/google/volteer/fw_config.c index 0538e74..08c3251 100644 --- a/src/mainboard/google/volteer/fw_config.c +++ b/src/mainboard/google/volteer/fw_config.c @@ -81,7 +81,8 @@ gpio_configure_pads(i2s_disable_pads, ARRAY_SIZE(i2s_disable_pads)); } if (fw_config_probe(FW_CONFIG(AUDIO, MAX98357_ALC5682I_I2S)) || - fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682I_I2S))) { + fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682I_I2S)) || + fw_config_probe(FW_CONFIG(AUDIO, RT1011_ALC5682I_I2S))) { printk(BIOS_INFO, "Configure GPIOs for I2S audio on UP3.\n"); gpio_configure_pads(i2s_up3_enable_pads, ARRAY_SIZE(i2s_up3_enable_pads)); gpio_configure_pads(dmic_enable_pads, ARRAY_SIZE(dmic_enable_pads)); diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 2a62505..79aae1d 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -14,6 +14,7 @@ option MAX98373_ALC5682I_I2S 2 option MAX98373_ALC5682_SNDW 3 option MAX98373_ALC5682I_I2S_UP4 4 + option RT1011_ALC5682I_I2S 6 end field TABLETMODE 11 option TABLETMODE_DISABLED 0 @@ -356,7 +357,7 @@
## Passive Policy register "policies.passive" = "{ - [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), + [0] = DPTF_PASSIVE(CPU, CPU, 95, 5000), [1] = DPTF_PASSIVE(CPU, TEMP_SENSOR_1, 65, 6000), [2] = DPTF_PASSIVE(CHARGER, TEMP_SENSOR_0, 65, 6000), [3] = DPTF_PASSIVE(CPU, TEMP_SENSOR_2, 65, 6000), diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb index 5f0f290..2c76d1a 100644 --- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -37,6 +37,20 @@ register "property_list[0].integer" = "1" device i2c 1a on end end + chip drivers/i2c/rt1011 + register "hid" = ""10EC1011"" + register "desc" = ""Realtek SPK AMP R"" + register "uid" = "0" + device i2c 3a on end + probe AUDIO_RT1011_ALC5682I_I2S + end + chip drivers/i2c/rt1011 + register "hid" = ""10EC1011"" + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "1" + device i2c 39 on end + probe AUDIO_RT1011_ALC5682I_I2S + end end device ref i2c1 on chip drivers/i2c/hid
Stanley Wu has uploaded a new patch set (#2). ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
Lindar change amp to ALC1011 adding ALC1011 amp acpi info into devicetree
BUG=b:171771736 BRANCH=None TEST=build and verify ALC1011 can be recognized.
Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4 Signed-off-by: stanley.wu stanley1.wu@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb 4 files changed, 19 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/47009/2
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Set Ready For Review
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 4:
(4 comments)
https://review.coreboot.org/c/coreboot/+/47009/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47009/2//COMMIT_MSG@2 PS2, Line 2: stanley.wu
Please change that to Stanley Wu.
Done
https://review.coreboot.org/c/coreboot/+/47009/2//COMMIT_MSG@10 PS2, Line 10: into
to
Done
https://review.coreboot.org/c/coreboot/+/47009/2//COMMIT_MSG@10 PS2, Line 10: adding
Add
Done
https://review.coreboot.org/c/coreboot/+/47009/2//COMMIT_MSG@17 PS2, Line 17: stanley.wu
Ditto.
Done
Hello build bot (Jenkins), Patrick Georgi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47009
to look at the new patch set (#5).
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
Lindar change amp to ALC1011 Add ALC1011 amp acpi info to devicetree
BUG=b:171771736 BRANCH=None TEST=build and verify ALC1011 can be recognized.
Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4 Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb 4 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/47009/5
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Set Ready For Review
Hello build bot (Jenkins), Patrick Georgi, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47009
to look at the new patch set (#8).
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
Lindar change amp to ALC1011 Add ALC1011 amp acpi info to devicetree
BUG=b:171771736 BRANCH=firmware-volteer-13521.B TEST=build and verify ALC1011 can be recognized.
Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4 Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb 4 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/47009/8
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 8: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 8:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47009/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47009/8//COMMIT_MSG@7 PS8, Line 7: b mb?
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee... PS8, Line 18: RT1011_ALC5682I_I2S i don't see this in program.star/config.star yet.
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: b/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee... PS8, Line 18: RT1011_ALC5682I_I2S
i don't see this in program.star/config.star yet.
Let me add you to review the CL.
Hello build bot (Jenkins), Patrick Georgi, Caveh Jalali, Zhuohao Lee, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47009
to look at the new patch set (#9).
Change subject: mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
Lindar change amp to ALC1011 Add ALC1011 amp acpi info to devicetree
BUG=b:171771736 BRANCH=firmware-volteer-13521.B TEST=build and verify ALC1011 can be recognized.
Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4 Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb 4 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/47009/9
Stanley Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 9:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47009/8//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47009/8//COMMIT_MSG@7 PS8, Line 7: b
mb?
Yes, already correct as mb.
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/47009/8/src/mainboard/google/voltee... PS8, Line 18: RT1011_ALC5682I_I2S
Let me add you to review the CL.
Zhuohao already added you in reviewer on CP:3402465 Thanks, Zhuohao.
Hello build bot (Jenkins), Patrick Georgi, Caveh Jalali, Zhuohao Lee, Zhuohao Lee,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/47009
to look at the new patch set (#10).
Change subject: mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
Lindar change amp to ALC1011 Add ALC1011 amp acpi info to devicetree
BUG=b:171771736 BRANCH=firmware-volteer-13521.B TEST=build and verify ALC1011 can be recognized.
Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4 Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb 4 files changed, 24 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/47009/10
Zhuohao Lee has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 10: Code-Review+1
Caveh Jalali has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
Patch Set 10: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47009 )
Change subject: mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011 ......................................................................
mb/google/volteer/variant/lindar: change speaker smart amplifier to ALC1011
Lindar change amp to ALC1011 Add ALC1011 amp acpi info to devicetree
BUG=b:171771736 BRANCH=firmware-volteer-13521.B TEST=build and verify ALC1011 can be recognized.
Change-Id: I4d83a19b3baa87cc926bb7c3a2cb96bf3165d2f4 Signed-off-by: Stanley Wu stanley1.wu@lcfc.corp-partner.google.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/47009 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Zhuohao Lee zhuohao@google.com Reviewed-by: Caveh Jalali caveh@chromium.org --- M src/mainboard/google/volteer/Kconfig.name M src/mainboard/google/volteer/fw_config.c M src/mainboard/google/volteer/variants/baseboard/devicetree.cb M src/mainboard/google/volteer/variants/lindar/overridetree.cb 4 files changed, 24 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Caveh Jalali: Looks good to me, approved Zhuohao Lee: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/volteer/Kconfig.name b/src/mainboard/google/volteer/Kconfig.name index b651430..0f9b6e2 100644 --- a/src/mainboard/google/volteer/Kconfig.name +++ b/src/mainboard/google/volteer/Kconfig.name @@ -22,6 +22,8 @@ select BOARD_GOOGLE_BASEBOARD_VOLTEER select SOC_INTEL_CSE_LITE_SKU select INTEL_CAR_NEM + select CHROMEOS_DSM_CALIB + select DRIVERS_I2C_RT1011
config BOARD_GOOGLE_MALEFOR bool "-> Malefor" diff --git a/src/mainboard/google/volteer/fw_config.c b/src/mainboard/google/volteer/fw_config.c index 50e8f93..5080d9b 100644 --- a/src/mainboard/google/volteer/fw_config.c +++ b/src/mainboard/google/volteer/fw_config.c @@ -86,7 +86,8 @@ } if (fw_config_probe(FW_CONFIG(AUDIO, MAX98357_ALC5682I_I2S)) || fw_config_probe(FW_CONFIG(AUDIO, MAX98373_ALC5682I_I2S)) || - fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S))) { + fw_config_probe(FW_CONFIG(AUDIO, MAX98360_ALC5682I_I2S)) || + fw_config_probe(FW_CONFIG(AUDIO, RT1011_ALC5682I_I2S))) { printk(BIOS_INFO, "Configure GPIOs for I2S audio on UP3.\n"); gpio_configure_pads(i2s_up3_enable_pads, ARRAY_SIZE(i2s_up3_enable_pads)); gpio_configure_pads(dmic_enable_pads, ARRAY_SIZE(dmic_enable_pads)); diff --git a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb index 7964885..bc1febb 100644 --- a/src/mainboard/google/volteer/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/volteer/variants/baseboard/devicetree.cb @@ -16,6 +16,7 @@ option MAX98373_ALC5682_SNDW 3 option MAX98373_ALC5682I_I2S_UP4 4 option MAX98360_ALC5682I_I2S 5 + option RT1011_ALC5682I_I2S 6 end field TABLETMODE 11 option TABLETMODE_DISABLED 0 diff --git a/src/mainboard/google/volteer/variants/lindar/overridetree.cb b/src/mainboard/google/volteer/variants/lindar/overridetree.cb index 64f5ab9..2e61071 100644 --- a/src/mainboard/google/volteer/variants/lindar/overridetree.cb +++ b/src/mainboard/google/volteer/variants/lindar/overridetree.cb @@ -35,7 +35,25 @@ register "property_list[0].type" = "ACPI_DP_TYPE_INTEGER" register "property_list[0].name" = ""realtek,jd-src"" register "property_list[0].integer" = "1" - device i2c 1a on end + device i2c 1a on + probe AUDIO RT1011_ALC5682I_I2S + end + end + chip drivers/i2c/rt1011 + register "desc" = ""Realtek SPK AMP L"" + register "uid" = "0" + register "name" = ""RTL"" + device i2c 38 on + probe AUDIO RT1011_ALC5682I_I2S + end + end + chip drivers/i2c/rt1011 + register "desc" = ""Realtek SPK AMP R"" + register "uid" = "1" + register "name" = ""RTR"" + device i2c 39 on + probe AUDIO RT1011_ALC5682I_I2S + end end end device ref i2c1 on
-
Caveh Jalali (Code Review) -
Patrick Georgi (Code Review)
-
Stanley Wu (Code Review)
-
Zhuohao Lee (Code Review)