Attention is currently required from: Andrey Petrov, Arthur Heymans, Christian Walter, Hung-Te Lin, Jakub Czapiga, Johnny Lin, Julius Werner, Martin L Roth, Ronak Kanabar, Tim Chu, Yidi Lin, Yu-Ping Wu.
Maximilian Brune has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77969?usp=email )
Change subject: treewide: Move stdlib.h to commonlib ......................................................................
Patch Set 9:
(7 comments)
File src/commonlib/bsd/include/commonlib/bsd/stdlib.h:
https://review.coreboot.org/c/coreboot/+/77969/comment/ae903f8a_804d6b3f : PS7, Line 10: #if CONFIG(COREBOOT_BUILD)
I think this is also not great (I know that that's not your patch, but I think a bunch of things wer […]
No worries. I am always happy to clean up old stuff. Done
https://review.coreboot.org/c/coreboot/+/77969/comment/4269eb40_0a805107 : PS7, Line 30: %s/%s/line %d
nit: This may just be my personal nitpick, but I find the `%s:%d %s():` from libpayload nicer than t […]
Agree. Done.
File src/drivers/intel/fsp2_0/silicon_init.c:
https://review.coreboot.org/c/coreboot/+/77969/comment/2f8a108b_f6ce477b : PS6, Line 8: #include <commonlib/bsd/stdlib.h>
Yeah, that policy isn't cleanly implemented everywhere in coreboot, but it's good to fix up things w […]
Oh yeah seems I forgot that one. Done.
File src/lib/device_tree.c:
https://review.coreboot.org/c/coreboot/+/77969/comment/e2db4526_b891ed31 : PS7, Line 5: #include <stdlib.h>
already included below
Done
File src/soc/intel/xeon_sp/spr/numa.c:
https://review.coreboot.org/c/coreboot/+/77969/comment/721e36a2_314ff00d : PS7, Line 4: #include <stdlib.h>
Not really necessary for files that already include `<types. […]
Done
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/77969/comment/d661d174_2c31f0c6 : PS7, Line 4: #include <stdlib.h>
same
Done
File src/soc/mediatek/mt8195/pcie.c:
https://review.coreboot.org/c/coreboot/+/77969/comment/0530fd8d_63fc47d3 : PS7, Line 3: #include <stdlib.h>
same
Done