Change in coreboot[master]: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341
Lean Sheng Tan has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341
The FSP-M/S/T related headers added are generated as per FSP v2341.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I98f738402490b47efa1a346f81db47857e384e13 --- A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspsUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FsptUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/MemInfoHob.h 6 files changed, 8,433 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/03/47803/1
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 39: ///< Offset 0 Index of Component Name There are some lines that are (unnecessary) too long. I guess since this is vendorcode and it is the same way done on other platforms (like tigerlake) and this is a file copied out of the FSP generation process it should be acceptable.
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 3027: This is a looong list of parameters...just for Fspm.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 39: ///< Offset 0 Index of Component Name
There are some lines that are (unnecessary) too long. […]
Yes Werner, this is the standard version across all platforms. WOuld you mind to provide +2 if you are alright with this? :)
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 3027:
This is a looong list of parameters...just for Fspm.
Yes you are right haha.. but i don't have control over this :P
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
Patch Set 1: Code-Review+2
(2 comments)
Will this ever be moved to 3rdparty/fsp?
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 39: ///< Offset 0 Index of Component Name
Yes Werner, this is the standard version across all platforms. […]
Yes, I got the context.
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... File src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h:
https://review.coreboot.org/c/coreboot/+/47803/1/src/vendorcode/intel/fsp/fs... PS1, Line 3027:
Yes you are right haha.. […]
Sure, just a nit.
Lean Sheng Tan has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
Patch Set 1:
Patch Set 1: Code-Review+2
(2 comments)
Will this ever be moved to 3rdparty/fsp?
Yes. It will be.
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/47803 )
Change subject: vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341 ......................................................................
vendorcode/intel/fsp: Add Elkhart Lake FSP headers for FSP v2341
The FSP-M/S/T related headers added are generated as per FSP v2341.
Signed-off-by: Tan, Lean Sheng lean.sheng.tan@intel.com Change-Id: I98f738402490b47efa1a346f81db47857e384e13 Reviewed-on: https://review.coreboot.org/c/coreboot/+/47803 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FirmwareVersionInfoHob.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspmUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FspsUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/FsptUpd.h A src/vendorcode/intel/fsp/fsp2_0/elkhartlake/MemInfoHob.h 6 files changed, 8,433 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
-
Lean Sheng Tan (Code Review) -
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)