Attention is currently required from: Terry Cheong.
Vamshi Krishna Gopal has posted comments on this change by Terry Cheong. ( https://review.coreboot.org/c/coreboot/+/82273?usp=email )
Change subject: Revert "mb/google/brox: Update verb table to fix headset detection"
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/82273/comment/51e5a6e3_a087fc5f?usp... :
PS2, Line 11: on some devices on
: brox
How was the original commit tested then? @Poornima?
We tested on SKU2 device where results are positive , we came to know later that in some devices mic detection breaks.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/82273?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0d8c092de6166b2c62f5ecc3deaf4960128e6106
Gerrit-Change-Number: 82273
Gerrit-PatchSet: 4
Gerrit-Owner: Terry Cheong
htcheong@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Poornima Tom
poornima.tom@intel.com
Gerrit-CC: Terry Cheong
htcheong@google.com
Gerrit-Attention: Terry Cheong
htcheong@chromium.org
Gerrit-Comment-Date: Tue, 28 May 2024 06:36:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Terry Cheong
htcheong@google.com