HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41673 )
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
src: Remove unused 'include <symbols.h>'
Change-Id: Ica355292eeda9c386b49db97f021566d52943d40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm64/armv8/mmu.c M src/arch/x86/acpi_s3.c M src/arch/x86/boot.c M src/cpu/x86/lapic/lapic_cpu_init.c M src/cpu/x86/mp_init.c M src/lib/cbfs.c M src/lib/decompressor.c M src/lib/fmap.c M src/lib/prog_loaders.c M src/lib/ramdetect.c M src/lib/selfboot.c M src/mainboard/emulation/qemu-riscv/rom_media.c M src/mainboard/google/gale/bootblock.c M src/mainboard/google/storm/bootblock.c M src/security/tpm/tspi/log.c M src/soc/cavium/cn81xx/soc.c M src/soc/mediatek/common/i2c.c M src/soc/mediatek/mt8173/i2c.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/arm_tf.c M src/soc/nvidia/tegra210/romstage.c M src/soc/nvidia/tegra210/spi.c M src/soc/qualcomm/sc7180/qspi.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/include/soc/soc.h 26 files changed, 0 insertions(+), 27 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41673/1
diff --git a/src/arch/arm64/armv8/mmu.c b/src/arch/arm64/armv8/mmu.c index 72e5cca..82afb9d 100644 --- a/src/arch/arm64/armv8/mmu.c +++ b/src/arch/arm64/armv8/mmu.c @@ -3,7 +3,6 @@ #include <assert.h> #include <stdint.h> #include <string.h> -#include <symbols.h>
#include <console/console.h> #include <arch/mmu.h> diff --git a/src/arch/x86/acpi_s3.c b/src/arch/x86/acpi_s3.c index 5ef0f7a..d0f3eca 100644 --- a/src/arch/x86/acpi_s3.c +++ b/src/arch/x86/acpi_s3.c @@ -10,7 +10,6 @@ #include <timestamp.h> #include <program_loading.h> #include <romstage_handoff.h> -#include <symbols.h> #include <cpu/x86/smm.h>
#if ENV_RAMSTAGE || ENV_POSTCAR diff --git a/src/arch/x86/boot.c b/src/arch/x86/boot.c index db9d69e..2866492 100644 --- a/src/arch/x86/boot.c +++ b/src/arch/x86/boot.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <program_loading.h> #include <ip_checksum.h> -#include <symbols.h>
int payload_arch_usable_ram_quirk(uint64_t start, uint64_t size) { diff --git a/src/cpu/x86/lapic/lapic_cpu_init.c b/src/cpu/x86/lapic/lapic_cpu_init.c index 58a633b..a3198cf 100644 --- a/src/cpu/x86/lapic/lapic_cpu_init.c +++ b/src/cpu/x86/lapic/lapic_cpu_init.c @@ -9,7 +9,6 @@ #include <halt.h> #include <lib.h> #include <string.h> -#include <symbols.h> #include <console/console.h> #include <device/device.h> #include <device/path.h> diff --git a/src/cpu/x86/mp_init.c b/src/cpu/x86/mp_init.c index caed8f4..98efde6 100644 --- a/src/cpu/x86/mp_init.c +++ b/src/cpu/x86/mp_init.c @@ -22,7 +22,6 @@ #include <device/path.h> #include <smp/atomic.h> #include <smp/spinlock.h> -#include <symbols.h> #include <timer.h> #include <thread.h>
diff --git a/src/lib/cbfs.c b/src/lib/cbfs.c index a3294de..17ce9b3 100644 --- a/src/lib/cbfs.c +++ b/src/lib/cbfs.c @@ -12,7 +12,6 @@ #include <security/vboot/vboot_common.h> #include <stdlib.h> #include <string.h> -#include <symbols.h> #include <timestamp.h>
#define ERROR(x...) printk(BIOS_ERR, "CBFS: " x) diff --git a/src/lib/decompressor.c b/src/lib/decompressor.c index 8ae9358..83b71b1 100644 --- a/src/lib/decompressor.c +++ b/src/lib/decompressor.c @@ -4,7 +4,6 @@ #include <commonlib/bsd/compression.h> #include <delay.h> #include <program_loading.h> -#include <symbols.h> #include <timestamp.h>
extern u8 compressed_bootblock[]; diff --git a/src/lib/fmap.c b/src/lib/fmap.c index 671a962..8545e23 100644 --- a/src/lib/fmap.c +++ b/src/lib/fmap.c @@ -6,7 +6,6 @@ #include <fmap.h> #include <stddef.h> #include <string.h> -#include <symbols.h>
#include "fmap_config.h"
diff --git a/src/lib/prog_loaders.c b/src/lib/prog_loaders.c index 7088d8d..cb8ac0b 100644 --- a/src/lib/prog_loaders.c +++ b/src/lib/prog_loaders.c @@ -13,7 +13,6 @@ #include <romstage_handoff.h> #include <rmodule.h> #include <stage_cache.h> -#include <symbols.h> #include <timestamp.h> #include <fit_payload.h> #include <security/vboot/vboot_common.h> diff --git a/src/lib/ramdetect.c b/src/lib/ramdetect.c index 328ca07..5ddacb1 100644 --- a/src/lib/ramdetect.c +++ b/src/lib/ramdetect.c @@ -1,7 +1,6 @@ /* SPDX-License-Identifier: GPL-2.0-only */
#include <types.h> -#include <symbols.h> #include <device/mmio.h> #include <ramdetect.h> #include <console/console.h> diff --git a/src/lib/selfboot.c b/src/lib/selfboot.c index c5ad525..eccac69 100644 --- a/src/lib/selfboot.c +++ b/src/lib/selfboot.c @@ -6,7 +6,6 @@ #include <stdint.h> #include <stdlib.h> #include <string.h> -#include <symbols.h> #include <cbfs.h> #include <lib.h> #include <bootmem.h> diff --git a/src/mainboard/emulation/qemu-riscv/rom_media.c b/src/mainboard/emulation/qemu-riscv/rom_media.c index 15989f2..a08aa89 100644 --- a/src/mainboard/emulation/qemu-riscv/rom_media.c +++ b/src/mainboard/emulation/qemu-riscv/rom_media.c @@ -1,6 +1,5 @@ /* SPDX-License-Identifier: GPL-2.0-only */ #include <boot_device.h> -#include <symbols.h>
/* This assumes that the CBFS resides at start of dram, which is true for the * default configuration. */ diff --git a/src/mainboard/google/gale/bootblock.c b/src/mainboard/google/gale/bootblock.c index 343fe65..109ff2b 100644 --- a/src/mainboard/google/gale/bootblock.c +++ b/src/mainboard/google/gale/bootblock.c @@ -2,7 +2,6 @@
#include <bootblock_common.h> #include <console/console.h> -#include <symbols.h>
#include "mmu.h" #include <soc/usbl_if.h> diff --git a/src/mainboard/google/storm/bootblock.c b/src/mainboard/google/storm/bootblock.c index e7ff6a3..852acfe 100644 --- a/src/mainboard/google/storm/bootblock.c +++ b/src/mainboard/google/storm/bootblock.c @@ -2,7 +2,6 @@
#include <bootblock_common.h> #include <console/console.h> -#include <symbols.h>
#include "mmu.h" #include <soc/usbl_if.h> diff --git a/src/security/tpm/tspi/log.c b/src/security/tpm/tspi/log.c index 07623f7..0529b86 100644 --- a/src/security/tpm/tspi/log.c +++ b/src/security/tpm/tspi/log.c @@ -4,7 +4,6 @@ #include <security/tpm/tspi.h> #include <region_file.h> #include <string.h> -#include <symbols.h> #include <cbmem.h> #include <bootstate.h> #include <vb2_sha.h> diff --git a/src/soc/cavium/cn81xx/soc.c b/src/soc/cavium/cn81xx/soc.c index 3545d55..b8b370c 100644 --- a/src/soc/cavium/cn81xx/soc.c +++ b/src/soc/cavium/cn81xx/soc.c @@ -14,7 +14,6 @@ #include <stddef.h> #include <stdlib.h> #include <string.h> -#include <symbols.h> #include <libbdk-boot/bdk-boot.h> #include <soc/ecam0.h> #include <console/uart.h> diff --git a/src/soc/mediatek/common/i2c.c b/src/soc/mediatek/common/i2c.c index 87925ba..e576560 100644 --- a/src/soc/mediatek/common/i2c.c +++ b/src/soc/mediatek/common/i2c.c @@ -5,7 +5,6 @@ #include <console/console.h> #include <delay.h> #include <timer.h> -#include <symbols.h> #include <device/mmio.h> #include <soc/i2c.h> #include <device/i2c_simple.h> diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index 0adee22..af2e029 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <delay.h> #include <device/i2c_simple.h> -#include <symbols.h> #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/i2c.h> diff --git a/src/soc/nvidia/tegra124/clock.c b/src/soc/nvidia/tegra124/clock.c index a2427fe..fb14c4e 100644 --- a/src/soc/nvidia/tegra124/clock.c +++ b/src/soc/nvidia/tegra124/clock.c @@ -12,7 +12,6 @@ #include <soc/maincpu.h> #include <soc/pmc.h> #include <soc/sysctr.h> -#include <symbols.h>
static struct clk_rst_ctlr *clk_rst = (void *)TEGRA_CLK_RST_BASE; static struct flow_ctlr *flow = (void *)TEGRA_FLOW_BASE; diff --git a/src/soc/nvidia/tegra124/spi.c b/src/soc/nvidia/tegra124/spi.c index 75cd9f7..6a25721 100644 --- a/src/soc/nvidia/tegra124/spi.c +++ b/src/soc/nvidia/tegra124/spi.c @@ -13,7 +13,6 @@ #include <soc/spi.h> #include <spi-generic.h> #include <spi_flash.h> -#include <symbols.h> #include <timer.h> #include <types.h>
diff --git a/src/soc/nvidia/tegra210/arm_tf.c b/src/soc/nvidia/tegra210/arm_tf.c index e12b201..684a3c4 100644 --- a/src/soc/nvidia/tegra210/arm_tf.c +++ b/src/soc/nvidia/tegra210/arm_tf.c @@ -5,7 +5,6 @@ #include <bl31.h> #include <soc/addressmap.h> #include <soc/console_uart.h> -#include <symbols.h> #include <types.h>
typedef struct bl31_plat_params { diff --git a/src/soc/nvidia/tegra210/romstage.c b/src/soc/nvidia/tegra210/romstage.c index 4f92c5f..3e807dc 100644 --- a/src/soc/nvidia/tegra210/romstage.c +++ b/src/soc/nvidia/tegra210/romstage.c @@ -14,7 +14,6 @@ #include <soc/sdram_configs.h> #include <soc/romstage.h> #include <soc/nvidia/tegra/apbmisc.h> -#include <symbols.h> #include <vendorcode/google/chromeos/chromeos.h>
void __weak romstage_mainboard_init(void) diff --git a/src/soc/nvidia/tegra210/spi.c b/src/soc/nvidia/tegra210/spi.c index eae8f39..4ccb926 100644 --- a/src/soc/nvidia/tegra210/spi.c +++ b/src/soc/nvidia/tegra210/spi.c @@ -13,7 +13,6 @@ #include <soc/addressmap.h> #include <soc/dma.h> #include <soc/spi.h> -#include <symbols.h> #include <types.h>
#if defined(CONFIG_DEBUG_SPI) && CONFIG_DEBUG_SPI diff --git a/src/soc/qualcomm/sc7180/qspi.c b/src/soc/qualcomm/sc7180/qspi.c index 675641b..ef2dbd3 100644 --- a/src/soc/qualcomm/sc7180/qspi.c +++ b/src/soc/qualcomm/sc7180/qspi.c @@ -8,7 +8,6 @@ #include <soc/qspi.h> #include <soc/gpio.h> #include <soc/clock.h> -#include <symbols.h> #include <assert.h> #include <gpio.h> #include <string.h> diff --git a/src/soc/qualcomm/sdm845/qspi.c b/src/soc/qualcomm/sdm845/qspi.c index 8c98316..a8e2dec 100644 --- a/src/soc/qualcomm/sdm845/qspi.c +++ b/src/soc/qualcomm/sdm845/qspi.c @@ -8,7 +8,6 @@ #include <soc/qspi.h> #include <soc/gpio.h> #include <soc/clock.h> -#include <symbols.h> #include <assert.h> #include <gpio.h> #include <string.h> diff --git a/src/soc/rockchip/common/include/soc/soc.h b/src/soc/rockchip/common/include/soc/soc.h index 67ee284..aaef606 100644 --- a/src/soc/rockchip/common/include/soc/soc.h +++ b/src/soc/rockchip/common/include/soc/soc.h @@ -3,8 +3,6 @@ #ifndef __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_SOC_H #define __COREBOOT_SRC_SOC_ROCKCHIP_COMMON_INCLUDE_SOC_SOC_H
-#include <symbols.h> - #define RK_CLRSETBITS(clr, set) ((((clr) | (set)) << 16) | set) #define RK_SETBITS(set) RK_CLRSETBITS(0, set) #define RK_CLRBITS(clr) RK_CLRSETBITS(clr, 0)
Hello build bot (Jenkins), Philipp Hug, Julius Werner, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41673
to look at the new patch set (#2).
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
src: Remove unused 'include <symbols.h>'
Change-Id: Ica355292eeda9c386b49db97f021566d52943d40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/arch/arm64/armv8/mmu.c M src/arch/x86/acpi_s3.c M src/arch/x86/boot.c M src/cpu/x86/lapic/lapic_cpu_init.c M src/cpu/x86/mp_init.c M src/mainboard/emulation/qemu-riscv/rom_media.c M src/mainboard/google/gale/bootblock.c M src/mainboard/google/storm/bootblock.c M src/security/tpm/tspi/log.c M src/soc/cavium/cn81xx/soc.c M src/soc/mediatek/common/i2c.c M src/soc/mediatek/mt8173/i2c.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/arm_tf.c M src/soc/nvidia/tegra210/romstage.c M src/soc/nvidia/tegra210/spi.c M src/soc/qualcomm/sc7180/qspi.c M src/soc/qualcomm/sdm845/qspi.c M src/soc/rockchip/common/include/soc/soc.h 20 files changed, 0 insertions(+), 21 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41673/2
Hello build bot (Jenkins), Philipp Hug, Julius Werner, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41673
to look at the new patch set (#3).
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
src: Remove unused 'include <symbols.h>'
Change-Id: Ica355292eeda9c386b49db97f021566d52943d40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/cpu/x86/lapic/lapic_cpu_init.c M src/security/vboot/common.c M src/soc/mediatek/mt8173/i2c.c M src/soc/nvidia/tegra124/clock.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/arm_tf.c 6 files changed, 0 insertions(+), 6 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41673/3
Hello build bot (Jenkins), Philipp Hug, Julius Werner, Aaron Durbin, ron minnich,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41673
to look at the new patch set (#4).
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
src: Remove unused 'include <symbols.h>'
Change-Id: Ica355292eeda9c386b49db97f021566d52943d40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/security/vboot/common.c M src/soc/mediatek/mt8173/i2c.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/arm_tf.c 4 files changed, 0 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/73/41673/4
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41673 )
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41673/4/src/soc/mediatek/mt8173/i2c... File src/soc/mediatek/mt8173/i2c.c:
https://review.coreboot.org/c/coreboot/+/41673/4/src/soc/mediatek/mt8173/i2c... PS4, Line 11: <device/mmio.h> includes twice ... I'll remove it in next patch
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41673 )
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/41673/4/src/soc/mediatek/mt8173/i2c... File src/soc/mediatek/mt8173/i2c.c:
https://review.coreboot.org/c/coreboot/+/41673/4/src/soc/mediatek/mt8173/i2c... PS4, Line 11: <device/mmio.h>
includes twice ... […]
included* twice :)
done: https://review.coreboot.org/c/coreboot/+/41676
Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41673 )
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
Patch Set 5: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41673 )
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41673 )
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
src: Remove unused 'include <symbols.h>'
Change-Id: Ica355292eeda9c386b49db97f021566d52943d40 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41673 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Aaron Durbin adurbin@chromium.org Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/security/vboot/common.c M src/soc/mediatek/mt8173/i2c.c M src/soc/nvidia/tegra124/spi.c M src/soc/nvidia/tegra210/arm_tf.c 4 files changed, 0 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Aaron Durbin: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/security/vboot/common.c b/src/security/vboot/common.c index 9701690..db51fa1 100644 --- a/src/security/vboot/common.c +++ b/src/security/vboot/common.c @@ -4,7 +4,6 @@ #include <cbmem.h> #include <console/console.h> #include <fmap.h> -#include <symbols.h> #include <vb2_api.h> #include <security/vboot/misc.h> #include <security/vboot/symbols.h> diff --git a/src/soc/mediatek/mt8173/i2c.c b/src/soc/mediatek/mt8173/i2c.c index 0adee22..af2e029 100644 --- a/src/soc/mediatek/mt8173/i2c.c +++ b/src/soc/mediatek/mt8173/i2c.c @@ -4,7 +4,6 @@ #include <console/console.h> #include <delay.h> #include <device/i2c_simple.h> -#include <symbols.h> #include <device/mmio.h> #include <soc/addressmap.h> #include <soc/i2c.h> diff --git a/src/soc/nvidia/tegra124/spi.c b/src/soc/nvidia/tegra124/spi.c index 75cd9f7..6a25721 100644 --- a/src/soc/nvidia/tegra124/spi.c +++ b/src/soc/nvidia/tegra124/spi.c @@ -13,7 +13,6 @@ #include <soc/spi.h> #include <spi-generic.h> #include <spi_flash.h> -#include <symbols.h> #include <timer.h> #include <types.h>
diff --git a/src/soc/nvidia/tegra210/arm_tf.c b/src/soc/nvidia/tegra210/arm_tf.c index e12b201..684a3c4 100644 --- a/src/soc/nvidia/tegra210/arm_tf.c +++ b/src/soc/nvidia/tegra210/arm_tf.c @@ -5,7 +5,6 @@ #include <bl31.h> #include <soc/addressmap.h> #include <soc/console_uart.h> -#include <symbols.h> #include <types.h>
typedef struct bl31_plat_params {
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41673 )
Change subject: src: Remove unused 'include <symbols.h>' ......................................................................
Patch Set 7:
Automatic boot test returned (PASS/FAIL/TOTAL): 4/0/4 Emulation targets: "QEMU x86 q35/ich9" using payload TianoCore : SUCCESS : https://lava.9esec.io/r/4600 "QEMU x86 q35/ich9" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4599 "QEMU x86 i440fx/piix4" using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/4598 "QEMU AArch64" using payload LinuxBoot_u-root_kexec : SUCCESS : https://lava.9esec.io/r/4597
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Aaron Durbin (Code Review)
-
Angel Pons (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)