Change in coreboot[master]: src/{device,drivers}: Remove unused '#include <device/pci.h>'
HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/37523 )
Change subject: src/{device,drivers}: Remove unused '#include <device/pci.h>' ......................................................................
src/{device,drivers}: Remove unused '#include <device/pci.h>'
Change-Id: I2ecbb81250876545f8ceef91710303ff4cc6a852 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/device_const.c M src/device/oprom/realmode/x86.c M src/device/oprom/realmode/x86_interrupts.c M src/device/oprom/yabel/device.c M src/device/oprom/yabel/interrupt.c M src/device/oprom/yabel/io.c M src/device/pci_ops.c M src/device/pci_rom.c M src/device/root_device.c M src/drivers/aspeed/common/aspeed_coreboot.h M src/drivers/generic/gfx/gfx.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/intel/gma/intel_ddi.c M src/drivers/intel/gma/opregion.c M src/drivers/intel/gma/vbt.c M src/drivers/xgi/common/xgi_coreboot.c M src/drivers/xgi/common/xgi_coreboot.h 17 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/37523/1
diff --git a/src/device/device_const.c b/src/device/device_const.c index c46f283..698648e 100644 --- a/src/device/device_const.c +++ b/src/device/device_const.c @@ -14,7 +14,6 @@ #include <console/console.h> #include <device/device.h> #include <device/path.h> -#include <device/pci.h> #include <device/pci_def.h> #include <device/resource.h>
diff --git a/src/device/oprom/realmode/x86.c b/src/device/oprom/realmode/x86.c index 8ba0241..095e427 100644 --- a/src/device/oprom/realmode/x86.c +++ b/src/device/oprom/realmode/x86.c @@ -17,7 +17,6 @@ #include <boot/coreboot_tables.h> #include <console/console.h> #include <delay.h> -#include <device/pci.h> #include <device/pci_ids.h> #include <pc80/i8259.h> #include <pc80/i8254.h> diff --git a/src/device/oprom/realmode/x86_interrupts.c b/src/device/oprom/realmode/x86_interrupts.c index c38da46..6ed547b 100644 --- a/src/device/oprom/realmode/x86_interrupts.c +++ b/src/device/oprom/realmode/x86_interrupts.c @@ -13,7 +13,6 @@
#include <arch/registers.h> #include <console/console.h> -#include <device/pci.h> #include <device/pci_ops.h>
/* we use x86emu's register file representation */ diff --git a/src/device/oprom/yabel/device.c b/src/device/oprom/yabel/device.c index 4a50068..4814829 100644 --- a/src/device/oprom/yabel/device.c +++ b/src/device/oprom/yabel/device.c @@ -39,7 +39,6 @@ #include "debug.h"
#include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h> #include <device/resource.h>
diff --git a/src/device/oprom/yabel/interrupt.c b/src/device/oprom/yabel/interrupt.c index 338156f..b9a708c 100644 --- a/src/device/oprom/yabel/interrupt.c +++ b/src/device/oprom/yabel/interrupt.c @@ -45,7 +45,6 @@ #include <x86emu/x86emu.h> #include "../x86emu/prim_ops.h"
-#include <device/pci.h> #include <device/pci_ops.h>
diff --git a/src/device/oprom/yabel/io.c b/src/device/oprom/yabel/io.c index 051a601..ec54ab0 100644 --- a/src/device/oprom/yabel/io.c +++ b/src/device/oprom/yabel/io.c @@ -41,7 +41,6 @@ #include <device/oprom/include/io.h> #include "io.h"
-#include <device/pci.h> #include <device/pci_ops.h> #include <device/resource.h>
diff --git a/src/device/pci_ops.c b/src/device/pci_ops.c index 431160e..3e5a2ee 100644 --- a/src/device/pci_ops.c +++ b/src/device/pci_ops.c @@ -13,7 +13,6 @@
#include <stdint.h> #include <console/console.h> -#include <device/pci.h> #include <device/pci_def.h> #include <device/pci_ops.h> #include <device/pci_type.h> diff --git a/src/device/pci_rom.c b/src/device/pci_rom.c index 3676f9c..25acc30 100644 --- a/src/device/pci_rom.c +++ b/src/device/pci_rom.c @@ -14,7 +14,6 @@ #include <console/console.h> #include <commonlib/endian.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> #include <string.h> diff --git a/src/device/root_device.c b/src/device/root_device.c index 6801b41..a891050 100644 --- a/src/device/root_device.c +++ b/src/device/root_device.c @@ -13,7 +13,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <reset.h>
const char mainboard_name[] = CONFIG_MAINBOARD_VENDOR " " CONFIG_MAINBOARD_PART_NUMBER; diff --git a/src/drivers/aspeed/common/aspeed_coreboot.h b/src/drivers/aspeed/common/aspeed_coreboot.h index d3b6981..088ea55 100644 --- a/src/drivers/aspeed/common/aspeed_coreboot.h +++ b/src/drivers/aspeed/common/aspeed_coreboot.h @@ -24,7 +24,6 @@
#include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h>
/* coreboot <--> kernel code interface */ diff --git a/src/drivers/generic/gfx/gfx.c b/src/drivers/generic/gfx/gfx.c index 76d311c..0e1a111 100644 --- a/src/drivers/generic/gfx/gfx.c +++ b/src/drivers/generic/gfx/gfx.c @@ -16,7 +16,6 @@ #include <arch/acpigen.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ids.h> #include <stdint.h> #include <string.h> diff --git a/src/drivers/i2c/rtd2132/rtd2132.c b/src/drivers/i2c/rtd2132/rtd2132.c index 22eeaa8..f70e6d3 100644 --- a/src/drivers/i2c/rtd2132/rtd2132.c +++ b/src/drivers/i2c/rtd2132/rtd2132.c @@ -15,7 +15,6 @@ #include <delay.h> #include <device/device.h> #include <device/smbus.h> -#include <device/pci.h> #include "chip.h"
/* Chip commands */ diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index d52b293..163a9ac 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -32,7 +32,6 @@ #include <console/console.h> #include <arch/acpi.h> #include <smbios.h> -#include <device/pci.h> #include <ec/google/chromeec/ec.h> #include <cpu/x86/tsc.h> #include <cpu/x86/cache.h> diff --git a/src/drivers/intel/gma/opregion.c b/src/drivers/intel/gma/opregion.c index 56449d0..1f46a76 100644 --- a/src/drivers/intel/gma/opregion.c +++ b/src/drivers/intel/gma/opregion.c @@ -17,7 +17,6 @@ #include <string.h> #include <cbfs.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> #include <console/console.h> diff --git a/src/drivers/intel/gma/vbt.c b/src/drivers/intel/gma/vbt.c index 603044a..93c3cf9 100644 --- a/src/drivers/intel/gma/vbt.c +++ b/src/drivers/intel/gma/vbt.c @@ -15,7 +15,6 @@ #include <device/pci_ops.h> #include <device/device.h> #include <string.h> -#include <device/pci.h> #include <drivers/intel/gma/opregion.h>
#include "i915.h" diff --git a/src/drivers/xgi/common/xgi_coreboot.c b/src/drivers/xgi/common/xgi_coreboot.c index caeb59d..9cfc558 100644 --- a/src/drivers/xgi/common/xgi_coreboot.c +++ b/src/drivers/xgi/common/xgi_coreboot.c @@ -17,7 +17,6 @@ #include <vbe.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ids.h> #include <device/pci_ops.h> #include <pc80/vga.h> diff --git a/src/drivers/xgi/common/xgi_coreboot.h b/src/drivers/xgi/common/xgi_coreboot.h index a850087..0d368ac 100644 --- a/src/drivers/xgi/common/xgi_coreboot.h +++ b/src/drivers/xgi/common/xgi_coreboot.h @@ -25,7 +25,6 @@ #include <device/mmio.h> #include <console/console.h> #include <device/device.h> -#include <device/pci.h> #include <device/pci_ops.h>
#include "initdef.h"
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37523
to look at the new patch set (#5).
Change subject: src/{device,drivers}: Remove unused '#include <device/pci.h>' ......................................................................
src/{device,drivers}: Remove unused '#include <device/pci.h>'
Change-Id: I2ecbb81250876545f8ceef91710303ff4cc6a852 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/device_const.c M src/device/oprom/realmode/x86.c M src/device/oprom/realmode/x86_interrupts.c M src/device/oprom/yabel/device.c M src/device/oprom/yabel/interrupt.c M src/device/oprom/yabel/io.c M src/device/pci_ops.c M src/device/pci_rom.c M src/device/root_device.c M src/drivers/aspeed/common/aspeed_coreboot.h M src/drivers/generic/gfx/gfx.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/intel/gma/intel_ddi.c M src/drivers/intel/gma/opregion.c M src/drivers/intel/gma/vbt.c M src/drivers/xgi/common/xgi_coreboot.c M src/drivers/xgi/common/xgi_coreboot.h 17 files changed, 0 insertions(+), 17 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/37523/5
Hello Patrick Rudolph, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/37523
to look at the new patch set (#6).
Change subject: src/{device,drivers}: Remove unused '#include <device/pci.h>' ......................................................................
src/{device,drivers}: Remove unused '#include <device/pci.h>'
Change-Id: I2ecbb81250876545f8ceef91710303ff4cc6a852 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/device/device_const.c M src/device/oprom/realmode/x86.c M src/device/oprom/realmode/x86_interrupts.c M src/device/oprom/yabel/device.c M src/device/oprom/yabel/interrupt.c M src/device/oprom/yabel/io.c M src/device/pci_ops.c M src/device/pci_rom.c M src/device/root_device.c M src/drivers/aspeed/common/aspeed_coreboot.h M src/drivers/generic/gfx/gfx.c M src/drivers/i2c/rtd2132/rtd2132.c M src/drivers/intel/gma/intel_ddi.c M src/drivers/intel/gma/opregion.c 14 files changed, 0 insertions(+), 14 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/23/37523/6
HAOUAS Elyes has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/37523 )
Change subject: src/{device,drivers}: Remove unused '#include <device/pci.h>' ......................................................................
Abandoned
-
HAOUAS Elyes (Code Review)