Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41166 )
Change subject: mb/google/volteer: early audio subsystem selection ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... File src/mainboard/google/volteer/variants/baseboard/cbi.c:
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... PS1, Line 11: MAYBE_STATIC_BSS int fw_initialized = 0; : MAYBE_STATIC_BSS uint32_t fw_config Why do these need to be static and the routine content to be written to be called more than once if this routine is only called once per boot? Do you forsee future cases where this will need to be called from more than one location in coreboot?
https://review.coreboot.org/c/coreboot/+/41166/1/src/mainboard/google/voltee... PS1, Line 15: fw_initialized If this routine will be called more than once, why not make db_type static and save off db_type instead of saving fw_initialized and have this check if db_type has been set, then can avoid line 25 in that case as well and just return db_type on any subsequent calls.
-
Nick Vaccaro (Code Review)