Attention is currently required from: Dinesh Gehlot, Kapil Porwal, Subrata Banik.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/77176?usp=email )
Change subject: {driver, soc/intel/cmn/cse}: Refactor ISH FW Version implementation
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
File src/soc/intel/common/block/cse/cse_lite.c:
https://review.coreboot.org/c/coreboot/+/77176/comment/61ab84c9_6743c3bf :
PS3, Line 1345: if (!is_cbmem_cse_info_valid(info) ||
nit: technically I guess this isn't really necessary here anymore because now that you always check the CRC right after the cbmem_add in the other functions, I don't think you can have an invalid one here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77176?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0242c26dd90d834815799f54740d8147ff9d45b7
Gerrit-Change-Number: 77176
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Comment-Date: Thu, 17 Aug 2023 18:23:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment