Julien Viard de Galbert has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25434 )
Change subject: soc/intel/denverton_ns: Enable MC Exception
......................................................................
Patch Set 19:
(2 comments)
This one should be okay now.
https://review.coreboot.org/c/coreboot/+/25434/3/src/soc/intel/denverton_ns/...
File src/soc/intel/denverton_ns/cpu.c:
https://review.coreboot.org/c/coreboot/+/25434/3/src/soc/intel/denverton_ns/...
PS3, Line 63: /* TODO install a fallback MC handler for each core in case OS does
: not provide one. Is it really needed ? */
What would the fallback MC handler do if an MC occurred?
No idea, to be honest I remember reading this in the BiosWriterGuide I no longer have access to...
https://review.coreboot.org/c/coreboot/+/25434/12/src/soc/intel/denverton_ns...
File src/soc/intel/denverton_ns/cpu.c:
https://review.coreboot.org/c/coreboot/+/25434/12/src/soc/intel/denverton_ns...
PS12, Line 65: needed ?
Ping
Removed the space.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/25434
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I9773c61d06bb6c68612e498a35b5ad22cd5a8a6e
Gerrit-Change-Number: 25434
Gerrit-PatchSet: 19
Gerrit-Owner: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: David Guckian
d.guckian20@gmail.com
Gerrit-Reviewer: David Guckian
david.guckian@intel.com
Gerrit-Reviewer: Julien Viard de Galbert
coreboot-review-ju@vdg.name
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Vanessa Eusebio
vanessa.f.eusebio@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jay Talbott
JayTalbott@sysproconsulting.com
Gerrit-Comment-Date: Wed, 11 Nov 2020 22:13:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jay Talbott
JayTalbott@sysproconsulting.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment