Stefan Reinauer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/27496 )
Change subject: sb/amd/cimx/sb800: Get rid of power button device in coreboot
......................................................................
Patch Set 4:
Please cut all the irrelevant pieces out of the commit message. This is way to verbose and hides all the relevant information. Why are you quoting Chrome EC in a change on non-ChromeOS machines? Why all the mention of some HDA audio stuff? What's the meaning of the two journalctl calls? And why do you post them and dmesg and evtest?
Also, please only one Signed-off-by: per physical person.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/27496
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0cbecb72f7e1bf3d051d3b7656c6af4d6f43b497
Gerrit-Change-Number: 27496
Gerrit-PatchSet: 4
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Piotr Król
piotr.krol@3mdeb.com
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Mon, 04 Mar 2019 05:44:13 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment