Change in coreboot[master]: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C
Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47984 )
Change subject: mb/clevo/cml-u: Configure IRQ as level triggered for HID over I2C ......................................................................
Patch Set 9:
(2 comments)
Given that the touchpad worked before
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47984/6//COMMIT_MSG@21 PS6, Line 21: successfully
ok ok... […]
As discussed on IRQ: Even when the device implements edge, level will work. probably this is done just for supporting shared IRQ lines, where edge wouldn't work reliably. For non-shared lines it probably doesn't make a difference at all, since active-low level also triggers one active-low edge interrupts.
https://review.coreboot.org/c/coreboot/+/47984/6/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/gpio.c:
https://review.coreboot.org/c/coreboot/+/47984/6/src/mainboard/clevo/cml-u/v... PS6, Line 65: PAD_CFG_GPI_APIC_HIGH
Given the double-inversion story, using _LOW here should work too, […]
changed as discussed on irc
-
Michael Niewöhner (Code Review)