Change in coreboot[master]: [TESTONLY] mb/asrock/b85m_pro4: Select DRIVERS_GENESYSLOGIC_GL9763E
Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44161 )
Change subject: [TESTONLY] mb/asrock/b85m_pro4: Select DRIVERS_GENESYSLOGIC_GL9763E ......................................................................
[TESTONLY] mb/asrock/b85m_pro4: Select DRIVERS_GENESYSLOGIC_GL9763E
This is just to build test the code.
Change-Id: Ib0b78cf874ab28d2b6ed687c1a63bcca3d788d2c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M src/mainboard/asrock/b85m_pro4/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44161/1
diff --git a/src/mainboard/asrock/b85m_pro4/Kconfig b/src/mainboard/asrock/b85m_pro4/Kconfig index dc65120..f4a2b89 100644 --- a/src/mainboard/asrock/b85m_pro4/Kconfig +++ b/src/mainboard/asrock/b85m_pro4/Kconfig @@ -6,6 +6,7 @@ def_bool y select BOARD_ROMSIZE_KB_8192 select CPU_INTEL_HASWELL + select DRIVERS_GENESYSLOGIC_GL9763E select HAVE_ACPI_RESUME select HAVE_ACPI_TABLES select HAVE_CMOS_DEFAULT
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/44161
to look at the new patch set (#3).
Change subject: configs/config.asrock_b85m_pro4...: Select GL9763E driver ......................................................................
configs/config.asrock_b85m_pro4...: Select GL9763E driver
This allows build-testing the code while it isn't used anywhere.
Change-Id: Ib0b78cf874ab28d2b6ed687c1a63bcca3d788d2c Signed-off-by: Angel Pons th3fanbus@gmail.com --- M configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/61/44161/3
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44161 )
Change subject: configs/config.asrock_b85m_pro4...: Select GL9763E driver ......................................................................
Patch Set 3: Code-Review+2
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44161 )
Change subject: configs/config.asrock_b85m_pro4...: Select GL9763E driver ......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44161/3/configs/config.asrock_b85m_... File configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100:
PS3: You're not going to add yet another qualifier to the end of the filename? 😋
debug_smmstore_hotplug_gcov_ubsan_em100_gl9763e ???
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44161 )
Change subject: configs/config.asrock_b85m_pro4...: Select GL9763E driver ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/44161/3/configs/config.asrock_b85m_... File configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100:
PS3:
You're not going to add yet another qualifier to the end of the filename? 😋 […]
It's quite long already, and some filesystems can't handle very long filepaths 😄
Angel Pons has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44161 )
Change subject: configs/config.asrock_b85m_pro4...: Select GL9763E driver ......................................................................
configs/config.asrock_b85m_pro4...: Select GL9763E driver
This allows build-testing the code while it isn't used anywhere.
Change-Id: Ib0b78cf874ab28d2b6ed687c1a63bcca3d788d2c Signed-off-by: Angel Pons th3fanbus@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44161 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Tim Wawrzynczak twawrzynczak@chromium.org --- M configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved Tim Wawrzynczak: Looks good to me, approved
diff --git a/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 b/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 index 49e7901..11a27bf 100644 --- a/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 +++ b/configs/config.asrock_b85m_pro4.debug_smmstore_hotplug_gcov_ubsan_em100 @@ -4,6 +4,7 @@ # + Debug options # + SMMSTORE # + Silicon Image SIL3114 driver +# + Genesys Logic GL9763E driver # + EM100 support CONFIG_COVERAGE=y CONFIG_UBSAN=y @@ -24,6 +25,7 @@ CONFIG_USBDEBUG=y CONFIG_USBDEBUG_DONGLE_FTDI_FT232H=y CONFIG_DRIVERS_SIL_3114=y +CONFIG_DRIVERS_GENESYSLOGIC_GL9763E=y # CONFIG_SQUELCH_EARLY_SMP is not set CONFIG_CONSOLE_SPI_FLASH=y CONFIG_POST_DEVICE_PCI_PCIE=y
-
Angel Pons (Code Review) -
Furquan Shaikh (Code Review)
-
Tim Wawrzynczak (Code Review)