Attention is currently required from: Henry Sun, Super Ni, Teddy Shih, Paul Menzel, Aseda Aboagye, Simon Yang, Ivan Chen, Felix Held.
Simon Yang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/63652 )
Change subject: mb/google/dedede/var/beadrix: Add a Proximity Sensor SX9324 for SAR
......................................................................
Patch Set 4:
(1 comment)
Patchset:
PS4:
Dear All, […]
Hi Teddy,
For the SAR p-sensor device, you can only keep common_soc_config.i2c[5] related settings, but its value of parameter speed_config may also needs HW's comment to ensure the clock frequency < 400k Hz.
In addition, for register SerialIoI2cMode, could you double check the schematic to review which controller does not connected a device in schematic actually, if so, please set it to PchSerialIoDisabled.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/63652
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If172d13aa62503547227adf91f049ea50b948888
Gerrit-Change-Number: 63652
Gerrit-PatchSet: 4
Gerrit-Owner: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Aseda Aboagye
aaboagye@google.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Ivan Chen
yulunchen@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Reviewer: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Reviewer: Teddy Shih
teddyshihau@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Eddy Lu
eddylu@ami.corp-partner.google.com
Gerrit-CC: Jack Cheng
jack.cheng@ecs.corp-partner.google.com
Gerrit-CC: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-CC: Simon Yang
simon1.yang@intel.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Super Ni
super.ni@intel.corp-partner.google.com
Gerrit-Attention: Teddy Shih
teddyshihau@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Aseda Aboagye
aaboagye@google.com
Gerrit-Attention: Simon Yang
simon1.yang@intel.corp-partner.google.com
Gerrit-Attention: Ivan Chen
yulunchen@google.com
Gerrit-Attention: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Tue, 03 May 2022 02:46:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Teddy Shih
teddyshih@ami.corp-partner.google.com
Gerrit-MessageType: comment