Change in coreboot[master]: ==== 2nd gen

[Marshall Dawson (Code Review)]

Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48545 )

Change subject: ==== 2nd gen
......................................................................

==== 2nd gen

Change-Id: I60e363da6ee6e22dbdf314c856cc5e3f1b0e776a
---
M util/amdfwtool/amdfwtool.c
1 file changed, 11 insertions(+), 2 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/45/48545/1

diff --git a/util/amdfwtool/amdfwtool.c b/util/amdfwtool/amdfwtool.c
index 36d669b..401cf20 100644
--- a/util/amdfwtool/amdfwtool.c
+++ b/util/amdfwtool/amdfwtool.c
@@ -323,6 +323,13 @@
    { .type = AMD_BIOS_INVALID },
 };

+struct second_gen_efs { /* todo: expand for Server products */
+	int gen:1; /* Client products only use bit 0 */
+	int reserved:31;
+} __attribute__((packed));
+
+#define EFS_SECOND_GEN 0
+
 typedef struct _embedded_firmware {
    uint32_t signature; /* 0x55aa55aa */
    uint32_t imc_entry;
@@ -333,7 +340,7 @@
    uint32_t bios0_entry; /* todo: add way to select correct entry */
    uint32_t bios1_entry;
    uint32_t bios2_entry;
-	uint32_t second_gen_efs; /* Client SKUs b0=1 is Gen1, b1=0 is Gen2, Servers TBD */
+	struct second_gen_efs efs_gen;
    uint32_t bios3_entry;
    uint32_t reserved_2Ch;
    uint32_t promontory_fw_ptr;
@@ -1187,6 +1194,8 @@
    	break;
    case PLATFORM_RAVEN:
    case PLATFORM_PICASSO:
+		/* amd_romsig->efs_gen introduced after RAVEN/PICASSO.
+		 * Leave as 0xffffffff for first gen */
    	amd_romsig->spi_readmode_f17_mod_00_2f = efs_spi_readmode;
    	amd_romsig->spi_fastspeed_f17_mod_00_2f = efs_spi_speed;
    	switch (efs_spi_micron_flag) {
@@ -1203,7 +1212,7 @@
    	break;
    case PLATFORM_RENOIR:
    case PLATFORM_LUCIENNE:
-		amd_romsig->second_gen_efs = 0xfffffffe;
+		amd_romsig->efs_gen.gen = EFS_SECOND_GEN;
    	amd_romsig->spi_readmode_f17_mod_30_3f = efs_spi_readmode;
    	amd_romsig->spi_fastspeed_f17_mod_30_3f = efs_spi_speed;
    	switch (efs_spi_micron_flag) {

[Marshall Dawson (Code Review)]

Marshall Dawson has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/48545 )

Change subject: ==== 2nd gen
......................................................................

Abandoned

Was supposed to be fixed up in CB:47769 prior to push