Attention is currently required from: Angel Pons, Arthur Heymans, Felix Held, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian, Paul Menzel, Simon Glass.
Simon Glass has posted comments on this change by Simon Glass. ( https://review.coreboot.org/c/coreboot/+/77712?usp=email )
Change subject: Introduce a coreboot Control Block (CCB)
......................................................................
Patch Set 10:
(1 comment)
Patchset:
PS10:
My objection is the -2. […]
We did discuss the various configuration mechanisms available...that was the first thing pointed out and I sent an RFC which I understood resolved the issue.
Overall I feel that Rome wasn't built in a day...this CL has suffered from feature creep from its original (fairly elegant and simple) implementation.
Printing to memory is fine, so long as you eventually get to a point where the memory is sent out to the UART. But you cannot guarantee that in the event of a delay or hamg, so it again defeats the purpose of being able to control console output.
As to the code flow, yes we could have a Kconfig to control when the console is inited, e.g. to allow CCB to only kick in after the initial part of the bootblock starts...but I would like to start somewhere, with the simplest possible implementation that provides useful (and not hamstrung) functionality.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/77712?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I04e946b33035a493e833500351a0483761252613
Gerrit-Change-Number: 77712
Gerrit-PatchSet: 10
Gerrit-Owner: Simon Glass
sjg@chromium.org
Gerrit-Reviewer: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-CC: Simon Glass
sjg@chromium.org
Gerrit-Attention: Simon Glass
sjg@chromium.org
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 27 Jun 2024 12:11:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Comment-In-Reply-To: Simon Glass
sjg@chromium.org
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de