Attention is currently required from: Nico Huber, Maulik V Vaghela, Paul Menzel, Subrata Banik, Aamir Bohra.
Ronak Kanabar has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45905 )
Change subject: drivers/intel/fsp2_0: Integrate FirmwareVersionInfo.h
......................................................................
Patch Set 12:
(4 comments)
File src/drivers/intel/fsp2_0/Kconfig.debug_blob:
https://review.coreboot.org/c/coreboot/+/45905/comment/9896387c_be97938e
PS5, Line 46: using new header 'FirmwareVersionInfo.h'.
why not use structure size itself i believe that the difference between FVI1 and FIV2 so you can kno […]
@Subrata both headers files will not be present at same time. string of both struct is different.
File src/drivers/intel/fsp2_0/hand_off_block.c:
https://review.coreboot.org/c/coreboot/+/45905/comment/d459d3cf_6550a92d
PS11, Line 244: #if
move to col 0, no need for tab
Done
https://review.coreboot.org/c/coreboot/+/45905/comment/26aba40f_4fa2180b
PS11, Line 246: #elif CONFIG(DISPLAY_FSP_VERSION_INFO_2)
same
Done
https://review.coreboot.org/c/coreboot/+/45905/comment/a85e2a55_83fa169b
PS11, Line 248: #endif
same
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45905
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I50f7cae9ed4fac60f91d86bdd3e884956627e4b5
Gerrit-Change-Number: 45905
Gerrit-PatchSet: 12
Gerrit-Owner: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Rudolph
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Maulik V Vaghela
maulik.v.vaghela@intel.com
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Aamir Bohra
aamir.bohra@intel.com
Gerrit-Comment-Date: Mon, 01 Feb 2021 12:09:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-MessageType: comment