Attention is currently required from: Hung-Te Lin, Yang Wu, Yidi Lin, Yu-Ping Wu.
Jiaxin Yu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79064?usp=email )
Change subject: mb/google/corsola/var/chinchou: Configure I2C and I2S interface for ALC5650
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
File src/mainboard/google/corsola/mainboard.c:
https://review.coreboot.org/c/coreboot/+/79064/comment/cc05345b_f7fe335e :
PS7, Line 43: mt_pll_set_aud_div(48 * KHz);
@jiaxin, does it mean we don't need to configure the clock for ALC5650?
No, beep sound we can use 26M clock to generate i2s bclk/lrck.
This can simplify the steps of configuring the APLL clock.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79064?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ibd098adb8d5568ad338bbfece0edfd0c38cbf854
Gerrit-Change-Number: 79064
Gerrit-PatchSet: 9
Gerrit-Owner: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Jiaxin Yu
jiaxin.yu@mediatek.corp-partner.google.com
Gerrit-Reviewer: Ruihai Zhou
zhouruihai@huaqin.corp-partner.google.com
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Xuxin Xiong
xuxinxiong@huaqin.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Attention: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 16 Nov 2023 06:39:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Jiaxin Yu
jiaxin.yu@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Comment-In-Reply-To: Yang Wu
wuyang5@huaqin.corp-partner.google.com
Gerrit-MessageType: comment