Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/19157 )
Change subject: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/#/c/19157/17//COMMIT_MSG Commit Message:
Line 7: amd/pi/00670F00: Add AMD PSP support for Stoney Ridge
This change touches agesawrapper.c file and moving amd_initcpuio() affects
Sorry, I must have missed the request -- I thought I suggested the possibility and don't recall any interest.
Split done.
https://review.coreboot.org/#/c/19157/14/src/northbridge/amd/pi/00670F00/psp... File src/northbridge/amd/pi/00670F00/psp.c:
Line 196: status_to_string(cmd_status));
Sure, displayed error _string_ will change since you have different cmd_sta
It don't see any commands that should expect anything coming back in header.status. I'll change the function to report it only if the PSP modifies the value..