Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph, EricR Lai.
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51712 )
Change subject: soc/intel/alderlake: Remove usage of '&' while memcpy
......................................................................
Patch Set 1:
(2 comments)
Patchset:
PS1:
I would squash this with CB:51704 (the immediately succeeding change)
File src/soc/intel/alderlake/meminit.c:
https://review.coreboot.org/c/coreboot/+/51712/comment/2c2425f2_6243d394
PS1, Line 31: memcpy(mem_cfg->RcompResistor, ddr_config->rcomp_resistor,
The `&` on this one is necessary, as `RcompResistor` is not an array.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51712
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I66e6b645c19bbd83f94830eb72516fcbab98e2cb
Gerrit-Change-Number: 51712
Gerrit-PatchSet: 1
Gerrit-Owner: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Comment-Date: Mon, 22 Mar 2021 15:14:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment