Aamir Bohra has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30809
Change subject: mb/google/hatch: Use USB2 Port 10 for BT over CnVi ......................................................................
mb/google/hatch: Use USB2 Port 10 for BT over CnVi
Integrated BT controller in CnVi uses USB port 10 for communication.
BUG=b:122552619 TEST=lsusb shows BT device
Change-Id: Iad1ca0e9419b534f50a3ce3fdcbd660caf8efb5c Signed-off-by: Aamir Bohra aamir.bohra@intel.com --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/30809/1
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index ca04507..8dd2d84 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -58,7 +58,7 @@ register "usb2_ports[6]" = "USB2_PORT_LONG(OC_SKIP)" # Camera register "usb2_ports[7]" = "USB2_PORT_EMPTY" register "usb2_ports[8]" = "USB2_PORT_EMPTY" - register "usb2_ports[9]" = "USB2_PORT_EMPTY" + register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # CnVi BT
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC2)" # Type-C Port 0 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC2)" # Type-C Port 1
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30809 )
Change subject: mb/google/hatch: Use USB2 Port 10 for BT over CnVi ......................................................................
mb/google/hatch: Use USB2 Port 10 for BT over CnVi
Integrated BT controller in CnVi uses USB port 10 for communication.
BUG=b:122552619 TEST=lsusb shows BT device
Change-Id: Iad1ca0e9419b534f50a3ce3fdcbd660caf8efb5c Signed-off-by: Aamir Bohra aamir.bohra@intel.com Reviewed-on: https://review.coreboot.org/c/30809 Reviewed-by: Rizwan Qureshi rizwan.qureshi@intel.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/hatch/variants/baseboard/devicetree.cb 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Rizwan Qureshi: Looks good to me, approved
diff --git a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb index ca04507..8dd2d84 100644 --- a/src/mainboard/google/hatch/variants/baseboard/devicetree.cb +++ b/src/mainboard/google/hatch/variants/baseboard/devicetree.cb @@ -58,7 +58,7 @@ register "usb2_ports[6]" = "USB2_PORT_LONG(OC_SKIP)" # Camera register "usb2_ports[7]" = "USB2_PORT_EMPTY" register "usb2_ports[8]" = "USB2_PORT_EMPTY" - register "usb2_ports[9]" = "USB2_PORT_EMPTY" + register "usb2_ports[9]" = "USB2_PORT_MID(OC_SKIP)" # CnVi BT
register "usb3_ports[0]" = "USB3_PORT_DEFAULT(OC2)" # Type-C Port 0 register "usb3_ports[1]" = "USB3_PORT_DEFAULT(OC2)" # Type-C Port 1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30809 )
Change subject: mb/google/hatch: Use USB2 Port 10 for BT over CnVi ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 93: device usb 0.0 on Why was this not updated to reflect the change for usb port for cnvi bt?
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 118: chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.4 on end : end Also, it means that this description is not correct when using CNVI BT. How do you plan to handle that?
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30809 )
Change subject: mb/google/hatch: Use USB2 Port 10 for BT over CnVi ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 93: device usb 0.0 on
Why was this not updated to reflect the change for usb port for cnvi bt?
I have to include that code, I did not add it to this CL , since did not test those changes in PO. I have created a bug to track it. https://partnerissuetracker.corp.google.com/issues/123375275
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 118: chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.4 on end : end
Also, it means that this description is not correct when using CNVI BT. […]
Ok. Since these are entries communicating individual port capabilities I do not see a conflict. Even if both Ports expose connection type as Bluetooth and non-connectable it would hold true since we are not using those ports externally. For the next board spin the USB2 P10 would be routed to M,2 connector. So we could remove the USB2 P5 entry and disable it.But this would get the discrete BT to not work on proto. https://partnerissuetracker.corp.google.com/issues/122552619
Please let me know on your thoughts.
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30809 )
Change subject: mb/google/hatch: Use USB2 Port 10 for BT over CnVi ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 118: chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.4 on end : end
Ok. Since these are entries communicating individual port capabilities I do not see a conflict. […]
It would be good to raise a separate bug to remove USB2 P5 use once we no longer need to support old boards.
Aamir Bohra has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30809 )
Change subject: mb/google/hatch: Use USB2 Port 10 for BT over CnVi ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:
https://review.coreboot.org/#/c/30809/2/src/mainboard/google/hatch/variants/... PS2, Line 118: chip drivers/usb/acpi : register "desc" = ""Bluetooth"" : register "type" = "UPC_TYPE_INTERNAL" : device usb 2.4 on end : end
It would be good to raise a separate bug to remove USB2 P5 use once we no longer need to support old […]
Ok. I have raised a bug for the same. https://partnerissuetracker.corp.google.com/issues/123500806
-
Aamir Bohra (Code Review) -
Furquan Shaikh (Code Review)
-
Patrick Georgi (Code Review)