Change in ...coreboot[master]: inteltool: Add multiple device IDs of Intel GPUs

[Felix Singer (Code Review)]

Felix Singer has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/30610

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

inteltool: Add multiple device IDs of Intel GPUs

* Intel UHD Graphics 615
* Intel UHD Graphics 620 (2x)
* Intel UHD Graphics 630 (2x)
* Intel Iris Graphics 655

Change-Id: I299a5fc082433b0aab4861a24aecbe83b61a404a
Signed-off-by: Felix Singer 
---
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
2 files changed, 21 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/10/30610/1

diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c
index 9a58ed8..bace49e 100644
--- a/util/inteltool/inteltool.c
+++ b/util/inteltool/inteltool.c
@@ -347,6 +347,18 @@
      "Intel(R) HD 5000 Graphics" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_5000_2,
      "Intel(R) HD 5000 Graphics" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_615,
+	  "Intel(R) UHD Graphics 615" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_620_1,
+	  "Intel(R) UHD Graphics 620" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_620_2,
+	  "Intel(R) UHD Graphics 620" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_1,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_2,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IRIS_PLUS_655,
+	  "Intel(R) Iris Plus Graphics 655" },
 };

#ifndef __DARWIN__
diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h
index d86ba35..8a36333 100644
--- a/util/inteltool/inteltool.h
+++ b/util/inteltool/inteltool.h
@@ -301,6 +301,15 @@
 #define PCI_DEVICE_ID_INTEL_HD_5000		0x0422
 #define PCI_DEVICE_ID_INTEL_HD_5000_1		0x0426
 #define PCI_DEVICE_ID_INTEL_HD_5000_2		0x042A
+#define PCI_DEVICE_ID_INTEL_UHD_615		0x591C
+#define PCI_DEVICE_ID_INTEL_UHD_620_1		0x5917
+#define PCI_DEVICE_ID_INTEL_UHD_620_2		0x3EA0
+#define PCI_DEVICE_ID_INTEL_UHD_630_1		0x3E92
+#define PCI_DEVICE_ID_INTEL_UHD_630_2		0x3E9B
+#define PCI_DEVICE_ID_INTEL_IRIS_PLUS_655	0x3EA5
+
+
+

#if !defined(__DARWIN__) && !defined(__FreeBSD__)
 typedef struct { uint32_t hi, lo; } msr_t;

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

Patch Set 10: Code-Review+1

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

Patch Set 10:

From where you get the IDs?
Pciutils database doesn't contain all entries and some are different.

Please use lowercase letters in hex values

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

Patch Set 10:
> Patch Set 10:
>
> From where you get the IDs?

I went through the ARK sites of Intel, starting at 6th gen up to 8th gen. Under the category "Processor Graphics" there is a point "Device ID".

Use this link and choose the family you are looking for: https://ark.intel.com/#@Processors
After that you will get a list of processors and by clicking on one of them you will get to the related ARK site.
> Pciutils database doesn't contain all entries and some are different.
>
> Please use lowercase letters in hex values

Seems like the spelling of the other IDs is mixed up a bit. Some are uppercase and some are lowercase.

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

Patch Set 10:
> Patch Set 10:
> > Patch Set 10:
> >
> > From where you get the IDs?
>
> I went through the ARK sites of Intel, starting at 6th gen up to 8th gen. Under the category "Processor Graphics" there is a point "Device ID".
>
> Use this link and choose the family you are looking for: https://ark.intel.com/#@Processors
> After that you will get a list of processors and by clicking on one of them you will get to the related ARK site.
> > Pciutils database doesn't contain all entries and some are different.
> >
> > Please use lowercase letters in hex values
>
> Seems like the spelling of the other IDs is mixed up a bit. Some are uppercase and some are lowercase.

I'll have a look later.

I've seen you refactor inteltool. Best moment for unitize it :)

[Thomas Heijligen (Code Review)]

Thomas Heijligen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

Patch Set 10: Code-Review+1

Looks good

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

Patch Set 12: Code-Review+2

(1 comment)

I'm curious: where is your list from?

https://review.coreboot.org/#/c/30610/12/util/inteltool/inteltool.h 
File util/inteltool/inteltool.h:

https://review.coreboot.org/#/c/30610/12/util/inteltool/inteltool.h@328 
PS12, Line 328: #define PCI_DEVICE_ID_INTEL_IRIS_PLUS_655	0x3EA5
If half of them are UHD 630, maybe we shouldn't use
the marketing names? The most elaborate list I know
is in the Linux sources (include/drm/i915_pciids.h),
with a little more distinguished names (less dis-
tinguished in the Iris case, though, *sigh*).

NB. most of this file seems to use lower-case hex

[Felix Singer (Code Review)]

Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

Patch Set 12:
> Patch Set 12: Code-Review+2
>
> (1 comment)
>
> I'm curious: where is your list from?

Choose a processor series from here: https://ark.intel.com/content/www/us/en/ark.html#@PanelLabel122139

Then you will get a list of all available CPUs. Choose one and you should get the specific ARK page. There you will find "Device ID".

I did this from 6th gen up to 8th gen.

[Nico Huber (Code Review)]

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/30610 )

Change subject: inteltool: Add multiple device IDs of Intel GPUs
......................................................................

inteltool: Add multiple device IDs of Intel GPUs

* Intel HD Graphics 510
* Intel HD Graphics 515
* Intel HD Graphics 520
* Intel HD Graphics 530 (2x)
* Intel UHD Graphics 615 (2x)
* Intel UHD Graphics 617
* Intel UHD Graphics 620 (3x)
* Intel UHD Graphics 630 (7x)
* Intel UHD Graphics 640
* Intel Iris Graphics 540
* Intel Iris Graphics 550
* Intel Iris Pro Graphics 580
* Intel Iris Plus Graphics 650
* Intel Iris Plus Graphics 655

Change-Id: I299a5fc082433b0aab4861a24aecbe83b61a404a
Signed-off-by: Felix Singer 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/30610
Reviewed-by: Nico Huber 
Reviewed-by: Paul Menzel 
Reviewed-by: Thomas Heijligen 
Tested-by: build bot (Jenkins) 
---
M util/inteltool/inteltool.c
M util/inteltool/inteltool.h
2 files changed, 72 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Nico Huber: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve
  Thomas Heijligen: Looks good to me, but someone else must approve

diff --git a/util/inteltool/inteltool.c b/util/inteltool/inteltool.c
index 93a7ffe..2066839 100644
--- a/util/inteltool/inteltool.c
+++ b/util/inteltool/inteltool.c
@@ -348,6 +348,54 @@
      "Intel(R) HD 5000 Graphics" },
    { PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_5000_2,
      "Intel(R) HD 5000 Graphics" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_510,
+	  "Intel(R) HD Graphics 510" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_515,
+	  "Intel(R) HD Graphics 515" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_520,
+	  "Intel(R) HD Graphics 520" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_530_1,
+	  "Intel(R) HD Graphics 530" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_HD_530_2,
+	  "Intel(R) HD Graphics 530" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_615_1,
+	  "Intel(R) UHD Graphics 615" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_615_2,
+	  "Intel(R) UHD Graphics 615" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_617,
+	  "Intel(R) UHD Graphics 617" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_620_1,
+	  "Intel(R) UHD Graphics 620" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_620_2,
+	  "Intel(R) UHD Graphics 620" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_620_3,
+	  "Intel(R) UHD Graphics 620" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_1,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_2,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_3,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_4,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_5,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_6,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_630_7,
+	  "Intel(R) UHD Graphics 630" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_UHD_640,
+	  "Intel(R) UHD Graphics 640" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IRIS_540,
+	  "Intel(R) Iris Graphics 540" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IRIS_550,
+	  "Intel(R) Iris Graphics 550" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IRIS_PRO_580,
+	  "Intel(R) Iris Pro Graphics 580" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IRIS_PLUS_650,
+	  "Intel(R) Iris Plus Graphics 650" },
+	{ PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_IRIS_PLUS_655,
+	  "Intel(R) Iris Plus Graphics 655" },
 };

#ifndef __DARWIN__
diff --git a/util/inteltool/inteltool.h b/util/inteltool/inteltool.h
index fb64811..ef094dc 100644
--- a/util/inteltool/inteltool.h
+++ b/util/inteltool/inteltool.h
@@ -302,6 +302,30 @@
 #define PCI_DEVICE_ID_INTEL_HD_5000		0x0422
 #define PCI_DEVICE_ID_INTEL_HD_5000_1		0x0426
 #define PCI_DEVICE_ID_INTEL_HD_5000_2		0x042A
+#define PCI_DEVICE_ID_INTEL_HD_510		0x1902
+#define PCI_DEVICE_ID_INTEL_HD_515		0x191E
+#define PCI_DEVICE_ID_INTEL_HD_520		0x1916
+#define PCI_DEVICE_ID_INTEL_HD_530_1		0x191B
+#define PCI_DEVICE_ID_INTEL_HD_530_2		0x1912
+#define PCI_DEVICE_ID_INTEL_UHD_615_1		0x591C
+#define PCI_DEVICE_ID_INTEL_UHD_615_2		0x591E
+#define PCI_DEVICE_ID_INTEL_UHD_617		0x87C0
+#define PCI_DEVICE_ID_INTEL_UHD_620_1		0x5917
+#define PCI_DEVICE_ID_INTEL_UHD_620_2		0x3EA0
+#define PCI_DEVICE_ID_INTEL_UHD_620_3		0x5916
+#define PCI_DEVICE_ID_INTEL_UHD_630_1		0x3E92
+#define PCI_DEVICE_ID_INTEL_UHD_630_2		0x3E9B
+#define PCI_DEVICE_ID_INTEL_UHD_630_3		0x3E91
+#define PCI_DEVICE_ID_INTEL_UHD_630_4		0x5912
+#define PCI_DEVICE_ID_INTEL_UHD_630_5		0x591B
+#define PCI_DEVICE_ID_INTEL_UHD_630_6		0x5902
+#define PCI_DEVICE_ID_INTEL_UHD_630_7		0x3E98
+#define PCI_DEVICE_ID_INTEL_UHD_640		0x5926
+#define PCI_DEVICE_ID_INTEL_IRIS_540		0x1926
+#define PCI_DEVICE_ID_INTEL_IRIS_550		0x1927
+#define PCI_DEVICE_ID_INTEL_IRIS_PRO_580	0x193B
+#define PCI_DEVICE_ID_INTEL_IRIS_PLUS_650	0x5927
+#define PCI_DEVICE_ID_INTEL_IRIS_PLUS_655	0x3EA5

#if !defined(__DARWIN__) && !defined(__FreeBSD__)
 typedef struct { uint32_t hi, lo; } msr_t;