Marc Jones has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/45968 )
Change subject: drivers/ipmi/ocp/ipmii_ocp.c: Clean up includes ......................................................................
drivers/ipmi/ocp/ipmii_ocp.c: Clean up includes
Remove #include "chip.h", which is not needed and causes a build problem in a later change. Alphabetise the #includes.
Change-Id: If19ccd144bd352a196adccd75f9f6f139eae4e4a Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/drivers/ipmi/ocp/ipmi_ocp.c R src/soc/intel/xeon_sp/cpx/cpx.h R src/soc/intel/xeon_sp/skx/skx.h 3 files changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/45968/1
diff --git a/src/drivers/ipmi/ocp/ipmi_ocp.c b/src/drivers/ipmi/ocp/ipmi_ocp.c index f96ce24..459b8e2 100644 --- a/src/drivers/ipmi/ocp/ipmi_ocp.c +++ b/src/drivers/ipmi/ocp/ipmi_ocp.c @@ -7,14 +7,14 @@ * end */
+#include <arch/cpu.h> #include <console/console.h> #include <device/device.h> #include <device/pnp.h> -#include <string.h> +#include <drivers/ipmi/ipmi_kcs.h> #include <intelblocks/cpulib.h> -#include <arch/cpu.h> -#include "chip.h" -#include "drivers/ipmi/ipmi_kcs.h" +#include <string.h> + #include "ipmi_ocp.h"
static int ipmi_set_processor_information_param1(struct device *dev) diff --git a/src/soc/intel/xeon_sp/cpx/chip.h b/src/soc/intel/xeon_sp/cpx/cpx.h similarity index 100% rename from src/soc/intel/xeon_sp/cpx/chip.h rename to src/soc/intel/xeon_sp/cpx/cpx.h diff --git a/src/soc/intel/xeon_sp/skx/chip.h b/src/soc/intel/xeon_sp/skx/skx.h similarity index 100% rename from src/soc/intel/xeon_sp/skx/chip.h rename to src/soc/intel/xeon_sp/skx/skx.h
Hello build bot (Jenkins), Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45968
to look at the new patch set (#2).
Change subject: drivers/ipmi/ocp/ipmii_ocp.c: Clean up includes ......................................................................
drivers/ipmi/ocp/ipmii_ocp.c: Clean up includes
Remove #include "chip.h", which is not needed and causes a build problem in a later change. Alphabetise the #includes.
Change-Id: If19ccd144bd352a196adccd75f9f6f139eae4e4a Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/drivers/ipmi/ocp/ipmi_ocp.c 1 file changed, 4 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/45968/2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45968 )
Change subject: drivers/ipmi/ocp/ipmii_ocp.c: Clean up includes ......................................................................
Patch Set 2: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/45968/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45968/2//COMMIT_MSG@7 PS2, Line 7: ii One `i` is enough
https://review.coreboot.org/c/coreboot/+/45968/2/src/drivers/ipmi/ocp/ipmi_o... File src/drivers/ipmi/ocp/ipmi_ocp.c:
https://review.coreboot.org/c/coreboot/+/45968/2/src/drivers/ipmi/ocp/ipmi_o... PS2, Line 17: I see some `uint8_t` lying around... #include <types.h>
Marc Jones has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45968 )
Change subject: drivers/ipmi/ocp/ipmii_ocp.c: Clean up includes ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45968/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/45968/2//COMMIT_MSG@7 PS2, Line 7: ii
One `i` is enough
Ack
https://review.coreboot.org/c/coreboot/+/45968/2/src/drivers/ipmi/ocp/ipmi_o... File src/drivers/ipmi/ocp/ipmi_ocp.c:
https://review.coreboot.org/c/coreboot/+/45968/2/src/drivers/ipmi/ocp/ipmi_o... PS2, Line 17:
I see some `uint8_t` lying around... #include <types. […]
Ack
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/45968
to look at the new patch set (#3).
Change subject: drivers/ipmi/ocp/ipmi_ocp.c: Clean up includes ......................................................................
drivers/ipmi/ocp/ipmi_ocp.c: Clean up includes
Remove #include "chip.h", which is not needed and causes a build problem in a later change. Alphabetise the #includes. Add <types.h>.
Change-Id: If19ccd144bd352a196adccd75f9f6f139eae4e4a Signed-off-by: Marc Jones marcjones@sysproconsulting.com --- M src/drivers/ipmi/ocp/ipmi_ocp.c 1 file changed, 5 insertions(+), 4 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/68/45968/3
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45968 )
Change subject: drivers/ipmi/ocp/ipmi_ocp.c: Clean up includes ......................................................................
Patch Set 3: Code-Review+2
Marc Jones has submitted this change. ( https://review.coreboot.org/c/coreboot/+/45968 )
Change subject: drivers/ipmi/ocp/ipmi_ocp.c: Clean up includes ......................................................................
drivers/ipmi/ocp/ipmi_ocp.c: Clean up includes
Remove #include "chip.h", which is not needed and causes a build problem in a later change. Alphabetise the #includes. Add <types.h>.
Change-Id: If19ccd144bd352a196adccd75f9f6f139eae4e4a Signed-off-by: Marc Jones marcjones@sysproconsulting.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/45968 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/ipmi/ocp/ipmi_ocp.c 1 file changed, 5 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/ipmi/ocp/ipmi_ocp.c b/src/drivers/ipmi/ocp/ipmi_ocp.c index f96ce24..07628ee 100644 --- a/src/drivers/ipmi/ocp/ipmi_ocp.c +++ b/src/drivers/ipmi/ocp/ipmi_ocp.c @@ -7,14 +7,15 @@ * end */
+#include <arch/cpu.h> #include <console/console.h> #include <device/device.h> #include <device/pnp.h> -#include <string.h> +#include <drivers/ipmi/ipmi_kcs.h> #include <intelblocks/cpulib.h> -#include <arch/cpu.h> -#include "chip.h" -#include "drivers/ipmi/ipmi_kcs.h" +#include <string.h> +#include <types.h> + #include "ipmi_ocp.h"
static int ipmi_set_processor_information_param1(struct device *dev)
-
Angel Pons (Code Review) -
Marc Jones (Code Review)