[M] Change in coreboot[main]: soc/mediatek/mt8196: Add unmask eint event for bootblock

[Yidi Lin (Code Review)]

Attention is currently required from: Chhao Chang, Jarried Lin, Yu-Ping Wu.

Yidi Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/84025?usp=email )

Change subject: soc/mediatek/mt8196: Add unmask eint event for bootblock
......................................................................

Patch Set 17:

(3 comments)

File src/soc/mediatek/common/eint_event.c:

https://review.coreboot.org/c/coreboot/+/84025/comment/ad183f92_b88ad9a1?usp... :
PS17, Line 15: uintptr_t reg;
> i<<2 is the offset of the next group of registers, not the base. […]

My approach do the same way.

https://review.coreboot.org/c/coreboot/+/84025/comment/d58719e8_398acb70?usp... :
PS17, Line 8: #define EVENT_CLEAN_MASK_OFFSET	0x880
            : #define EVENT_MASK_OFFSET	0x800
            : #define EINT_VALUE		0xFFFFFFFF
            : 
            : void enable_eint_event(uintptr_t base, unsigned int port)
            : {
            : 	unsigned int i;
            : 	uintptr_t reg;
            : 
            : 	for (i = 0; i < port; i++) {
            : 		reg = base + EVENT_CLEAN_MASK_OFFSET + (i << 2);
            : 		write32((uint32_t *)reg, EINT_VALUE);
            : 	}
            : }
> Since EINT_BASE is already used in eint_event.h, an error will occur if it is not defined.

That is why there should be eint_event_common.c.

File src/soc/mediatek/common/include/soc/eint_event.h:

https://review.coreboot.org/c/coreboot/+/84025/comment/7aabbec6_d1c435d9?usp... :
PS17, Line 17: struct eint_info {
             : 	uintptr_t base;
             : 	unsigned int eint_num;
             : };
> As long as it is a mobile phone IC, this structure is needed

It has nothing to do with the type of IC.