Attention is currently required from: Furquan Shaikh, Martin Roth, Mathew King.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50007 )
Change subject: mb/google/mancomb: Add new mainboard
......................................................................
Patch Set 7:
(1 comment)
File src/mainboard/google/mancomb/Kconfig:
https://review.coreboot.org/c/coreboot/+/50007/comment/f0d2aaa9_044e5ab1
PS7, Line 11:
select BOARD_ROMSIZE_KB_16384 is missing here
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50007
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1264f44a0b986f7f7c89ac7b42f1e4e4119a35e6
Gerrit-Change-Number: 50007
Gerrit-PatchSet: 7
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Bhanu Prakash Maiya
bhanumaiya@google.com
Gerrit-CC: Felix Held
felix-coreboot@felixheld.de
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Mathew King
mathewk@chromium.org
Gerrit-Comment-Date: Fri, 05 Feb 2021 14:19:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment