Change in coreboot[master]: mainboard/emulation/qemu-i440fx: Select HAVE_ASAN_IN_ROMSTAGE
Harshit Sharma has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44282 )
Change subject: mainboard/emulation/qemu-i440fx: Select HAVE_ASAN_IN_ROMSTAGE ......................................................................
mainboard/emulation/qemu-i440fx: Select HAVE_ASAN_IN_ROMSTAGE
Enable ASan in romstage as it has been tested.
Change-Id: I3b5263f5342a78968d9a1ecf72996fff0946b204 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com --- M src/mainboard/emulation/qemu-i440fx/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/44282/1
diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 06ac685..9187b05 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -13,6 +13,7 @@ select BOARD_ROMSIZE_KB_16384 if VBOOT select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT + select HAVE_ASAN_IN_ROMSTAGE
config VBOOT select VBOOT_MUST_REQUEST_DISPLAY
Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44282 )
Change subject: mainboard/emulation/qemu-i440fx: Select HAVE_ASAN_IN_ROMSTAGE ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44282 )
Change subject: mainboard/emulation/qemu-i440fx: Select HAVE_ASAN_IN_ROMSTAGE ......................................................................
mainboard/emulation/qemu-i440fx: Select HAVE_ASAN_IN_ROMSTAGE
Enable ASan in romstage as it has been tested.
Change-Id: I3b5263f5342a78968d9a1ecf72996fff0946b204 Signed-off-by: Harshit Sharma harshitsharmajs@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/44282 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Werner Zeh werner.zeh@siemens.com --- M src/mainboard/emulation/qemu-i440fx/Kconfig 1 file changed, 1 insertion(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Werner Zeh: Looks good to me, approved
diff --git a/src/mainboard/emulation/qemu-i440fx/Kconfig b/src/mainboard/emulation/qemu-i440fx/Kconfig index 06ac685..9187b05 100644 --- a/src/mainboard/emulation/qemu-i440fx/Kconfig +++ b/src/mainboard/emulation/qemu-i440fx/Kconfig @@ -13,6 +13,7 @@ select BOARD_ROMSIZE_KB_16384 if VBOOT select MAINBOARD_HAS_NATIVE_VGA_INIT select MAINBOARD_FORCE_NATIVE_VGA_INIT + select HAVE_ASAN_IN_ROMSTAGE
config VBOOT select VBOOT_MUST_REQUEST_DISPLAY
-
Harshit Sharma (Code Review) -
Patrick Georgi (Code Review)
-
Werner Zeh (Code Review)