build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/25046 )
Change subject: drivers/vpd: Add VPD support ......................................................................
Patch Set 5:
(8 comments)
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/lib_vpd.c File src/drivers/vpd/lib_vpd.c:
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/lib_vpd.c@32 PS5, Line 32: if (i >= max_len) return VPD_FAIL; trailing statements should be on next line
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/lib_vpd.c@72 PS5, Line 72: switch (type) { switch and case should be at the same indent
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/lib_vpd.c@77 PS5, Line 77: if (VPD_OK != decodeLen(max_len - *consumed, suspect code indent for conditional statements (24, 40)
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/lib_vpd.c@77 PS5, Line 77: if (VPD_OK != decodeLen(max_len - *consumed, Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/lib_vpd.c@89 PS5, Line 89: if (VPD_OK != decodeLen(max_len - *consumed, suspect code indent for conditional statements (24, 40)
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/lib_vpd.c@89 PS5, Line 89: if (VPD_OK != decodeLen(max_len - *consumed, Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/vpd.c File src/drivers/vpd/vpd.c:
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/vpd.c@194 PS5, Line 194: while (VPD_OK == decodeVpdString(vpd->ro_size, vpd->blob, Comparisons should place the constant on the right side of the test
https://review.coreboot.org/#/c/25046/5/src/drivers/vpd/vpd.c@200 PS5, Line 200: while (VPD_OK == decodeVpdString(vpd->rw_size, Comparisons should place the constant on the right side of the test
-
build bot (Jenkins) (Code Review)