8 comments:
File src/drivers/vpd/lib_vpd.c:
Patch Set #5, Line 32: if (i >= max_len) return VPD_FAIL;
trailing statements should be on next line
Patch Set #5, Line 72: switch (type) {
switch and case should be at the same indent
Patch Set #5, Line 77: if (VPD_OK != decodeLen(max_len - *consumed,
suspect code indent for conditional statements (24, 40)
Patch Set #5, Line 77: if (VPD_OK != decodeLen(max_len - *consumed,
Comparisons should place the constant on the right side of the test
Patch Set #5, Line 89: if (VPD_OK != decodeLen(max_len - *consumed,
suspect code indent for conditional statements (24, 40)
Patch Set #5, Line 89: if (VPD_OK != decodeLen(max_len - *consumed,
Comparisons should place the constant on the right side of the test
Patch Set #5, Line 194: while (VPD_OK == decodeVpdString(vpd->ro_size, vpd->blob,
Comparisons should place the constant on the right side of the test
Patch Set #5, Line 200: while (VPD_OK == decodeVpdString(vpd->rw_size,
Comparisons should place the constant on the right side of the test
To view, visit change 25046. To unsubscribe, or for help writing mail filters, visit settings.