Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36527 )
Change subject: timestamps: COLLECT_TIMESTAMPS is always optional ......................................................................
Patch Set 3:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36527/3//COMMIT_MSG@15 PS3, Line 15: We could implement get_us_since_boot() over monotonic timer.
I doubt if amd/stoneyridge/monotonic_timer.c version does the same. Or intel/quark/tsc_freq.c. […]
Ya. It's partially my fault, I think. My point was that we could use it in that way once we remove that bit of code in src/cpu/x86/tsc/delay_tsc.c and formalize on the semantics.
Current comment in timer.h: Obtain the current monotonic time. The assumption is that the time counts * up from the value 0 with value 0 being the point when the timer was * initialized. Additionally, the timer is assumed to only be valid for the * duration of the boot.
It's ambiguous, I admit, but we currently make no claims about it continuing to count up across stages. We can definitely do that, though.
-
Aaron Durbin (Code Review)