Attention is currently required from: Martin L Roth, David Hendricks, ron minnich.
Maxim Polyakov has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/67132 )
Change subject: intelp2m/patform/sunrise: Add unit tests ......................................................................
Patch Set 15:
(3 comments)
Patchset:
PS15: Thanks for the review
File util/intelp2m/Makefile:
https://review.coreboot.org/c/coreboot/+/67132/comment/8898812a_18c20cea PS14, Line 9: go build -v -o $(PROJECT_NAME)
I find myself wondering why you have the -o here. In my experience, a go build -v would build . […]
Yes, you're right. The -o option is not required here. In any case, the Makefile requires changes (project directory tree, compiler options). Maybe i need more time to reflect on this. For now, I'd rather keep it as it is.
File util/intelp2m/platforms/test/suite.go:
https://review.coreboot.org/c/coreboot/+/67132/comment/67e55c33_33e75c78 PS14, Line 47: err = fmt.Errorf(format, "LONG", m.Long, actually)
in code like this it's a bit more idiomatic to do this: […]
I agree. Fixed
-
Maxim Polyakov (Code Review)