Attention is currently required from: Arthur Heymans, Patrick Rudolph, Iru Cai.
Iru Cai (vimacs) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55947 )
Change subject: arch/x86: Save resume vector to stack in x86_64 mode
......................................................................
Patch Set 3:
(1 comment)
File src/arch/x86/wakeup.S:
https://review.coreboot.org/c/coreboot/+/55947/comment/a546dd50_255831b0
PS2, Line 20: It's OK to overwrite the return address at (%rsp) because this
: * function doesn't return.
Is that happening? This looks like a 32bit op so I would expect the upper 4 bytes of 4(%rsp) to be p […]
What I said is that (%rsp) has the 8-byte return address from the caller of __wakeup in 64-bit mode, and move to 4(%rsp) writes its higher 4 bytes.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/55947
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I45f2678071b2511c0af5dce9d9b73ac70dfd7252
Gerrit-Change-Number: 55947
Gerrit-PatchSet: 3
Gerrit-Owner: Iru Cai (vimacs)
mytbk920423@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Iru Cai
mytbk920423@gmail.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Attention: Iru Cai
mytbk920423@gmail.com
Gerrit-Comment-Date: Mon, 05 Jul 2021 13:14:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment