build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/29162 )
Change subject: soc/intel/icelake: Initial SoC commit ......................................................................
Patch Set 2:
(9 comments)
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/acpi.c File src/soc/intel/icelake/acpi.c:
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/acpi.c@208 PS2, Line 208: if (IS_ENABLED(CONFIG_CONSOLE_CBMEM)) suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/bootblock/pch.... File src/soc/intel/icelake/bootblock/pch.c:
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/bootblock/pch.... PS2, Line 53: #define TCOEN (1 << 1) /* Enable TCO I/O range decode. */ line over 80 characters
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/bootblock/pch.... PS2, Line 124: if (pmc_reg_value != 0xFFFFFFFF) that open brace { should be on the previous line
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/bootblock/repo... File src/soc/intel/icelake/bootblock/report_platform.c:
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/bootblock/repo... PS2, Line 104: int j=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/bootblock/repo... PS2, Line 113: p[12]=0; spaces required around that '=' (ctx:VxV)
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/cbmem.c File src/soc/intel/icelake/cbmem.c:
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/cbmem.c@20 PS2, Line 20: /* not implemented yet */ code indent should use tabs where possible
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/include/soc/ro... File src/soc/intel/icelake/include/soc/romstage.h:
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/include/soc/ro... PS2, Line 22: void mainboard_memory_init_params(FSPM_UPD *mupd); need consistent spacing around '*' (ctx:WxV)
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/sd.c File src/soc/intel/icelake/sd.c:
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/sd.c@19 PS2, Line 19: int sd_fill_soc_gpio_info(struct acpi_gpio* gpio, struct device *dev) "foo* bar" should be "foo *bar"
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/smihandler.c File src/soc/intel/icelake/smihandler.c:
https://review.coreboot.org/#/c/29162/2/src/soc/intel/icelake/smihandler.c@8... PS2, Line 83: return ; space prohibited before semicolon