Arthur Heymans has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34000
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
soc/intel/skylake: Add Kabylake-R microcode update files
Change-Id: I8b9fc3ba0d6dc6e0001b40518aae2d26c1184dc8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/Makefile.inc 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/34000/1
diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc index 25dce05..5e4b111 100644 --- a/src/soc/intel/skylake/Makefile.inc +++ b/src/soc/intel/skylake/Makefile.inc @@ -91,6 +91,8 @@ cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-4e-03 # Kabylake H0, Y0 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-09 +# Kabylake-R +cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0a endif # Missing for Skylake C0 (0x406e2), Kabylake G0 (0x406e8), Kabylake HA0 (0x506e8) # since those are probably pre-release samples.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 1: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 1: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 1: Code-Review+2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 1:
(3 comments)
added some noise. I don't mind to submit PS1, though
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc File src/soc/intel/skylake/Makefile.inc:
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc@8... PS1, Line 87: # Kabylake HB0 looks like a typo, I assume it means "Kabylake H" "B0"
also S0
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc@9... PS1, Line 92: # Kabylake H0, Y0 actually this is H0, J0, J1
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc@9... PS1, Line 94: # Kabylake-R and this is Y0
Hello Kyösti Mälkki, Matthew Garrett, Angel Pons, Matt DeVillier, build bot (Jenkins), Nico Huber,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34000
to look at the new patch set (#2).
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
soc/intel/skylake: Add Kabylake-R microcode update files
This also corrects some CPU naming in comments.
Change-Id: I8b9fc3ba0d6dc6e0001b40518aae2d26c1184dc8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz --- M src/soc/intel/skylake/Makefile.inc 1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/00/34000/2
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 2: Code-Review+2
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 2: Code-Review+2
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 2: Code-Review+2
(1 comment)
I can't help but add some noise as well...
https://review.coreboot.org/#/c/34000/2/src/soc/intel/skylake/Makefile.inc File src/soc/intel/skylake/Makefile.inc:
https://review.coreboot.org/#/c/34000/2/src/soc/intel/skylake/Makefile.inc@8... PS2, Line 87: Extremely minor: missing a comma?
Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
soc/intel/skylake: Add Kabylake-R microcode update files
This also corrects some CPU naming in comments.
Change-Id: I8b9fc3ba0d6dc6e0001b40518aae2d26c1184dc8 Signed-off-by: Arthur Heymans arthur@aheymans.xyz Reviewed-on: https://review.coreboot.org/c/coreboot/+/34000 Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/intel/skylake/Makefile.inc 1 file changed, 4 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Kyösti Mälkki: Looks good to me, approved Nico Huber: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/soc/intel/skylake/Makefile.inc b/src/soc/intel/skylake/Makefile.inc index 25dce05..20fba29 100644 --- a/src/soc/intel/skylake/Makefile.inc +++ b/src/soc/intel/skylake/Makefile.inc @@ -84,13 +84,15 @@ ifeq ($(CONFIG_SKYLAKE_SOC_PCH_H),y) # Skylake H Q0 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-5e-03 -# Kabylake HB0 +# Kabylake H B0 S0 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-9e-09 else # Skylake D0 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-4e-03 -# Kabylake H0, Y0 +# Kabylake H0, J0, J1 cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-09 +# Kabylake Y0 +cpu_microcode_bins += 3rdparty/intel-microcode/intel-ucode/06-8e-0a endif # Missing for Skylake C0 (0x406e2), Kabylake G0 (0x406e8), Kabylake HA0 (0x506e8) # since those are probably pre-release samples.
-
Angel Pons (Code Review) -
Arthur Heymans (Code Review)
-
Kyösti Mälkki (Code Review)
-
Nico Huber (Code Review)