Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34000 )
Change subject: soc/intel/skylake: Add Kabylake-R microcode update files ......................................................................
Patch Set 1:
(3 comments)
added some noise. I don't mind to submit PS1, though
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc File src/soc/intel/skylake/Makefile.inc:
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc@8... PS1, Line 87: # Kabylake HB0 looks like a typo, I assume it means "Kabylake H" "B0"
also S0
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc@9... PS1, Line 92: # Kabylake H0, Y0 actually this is H0, J0, J1
https://review.coreboot.org/#/c/34000/1/src/soc/intel/skylake/Makefile.inc@9... PS1, Line 94: # Kabylake-R and this is Y0