Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50317 )
Change subject: src/ec/lenovo/h8/acpi/battery.asl: Convert to ASL 2.0
......................................................................
Patch Set 3:
(2 comments)
File src/ec/lenovo/h8/acpi/battery.asl:
https://review.coreboot.org/c/coreboot/+/50317/comment/71f6e89d_037a6de2
PS3, Line 118: Local2 -= 0x10000
This looks wrong.
Done
https://review.coreboot.org/c/coreboot/+/50317/comment/42cf4139_07d0ce0a
PS3, Line 169: Local0 = Local2 % 20 // FIXME: Local0 not used
So, why is this kept?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50317
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5de6c7da2440d682378a4ceb89b4bedd689dad60
Gerrit-Change-Number: 50317
Gerrit-PatchSet: 3
Gerrit-Owner: Elyes Haouas
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: 9elements QA
hardwaretestrobot@gmail.com
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Mon, 14 Nov 2022 10:21:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment