Attention is currently required from: Hung-Te Lin, Raul Rangel, Frans Hendriks, Mariusz Szafrański, Angel Pons, Andrey Petrov, Kyösti Mälkki, Patrick Rudolph, Erik van den Bogaert, Nico Huber, Marshall Dawson, Lee Leahy, Christian Walter, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Huang Jin, Michal Motyl, Felix Held. Hello Hung-Te Lin, build bot (Jenkins), Raul Rangel, Patrick Georgi, Frans Hendriks, Mariusz Szafrański, Angel Pons, Andrey Petrov, Kyösti Mälkki, Patrick Rudolph, Lance Zhao, Erik van den Bogaert, Jason Glenesk, Nico Huber, Lee Leahy, Marshall Dawson, Christian Walter, Suresh Bellampalli, Tim Wawrzynczak, Vanessa Eusebio, Huang Jin, Michal Motyl, HAOUAS Elyes, Felix Held,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/61309
to look at the new patch set (#13).
Change subject: treewide: Remove "ERROR: "/"WARN: " prefixes from log messages ......................................................................
treewide: Remove "ERROR: "/"WARN: " prefixes from log messages
Now that the console system itself will clearly differentiate loglevels, it is no longer necessary to explicitly add "ERROR: " in front of every BIOS_ERR message to help it stand out more (and allow automated tooling to grep for it). Removing all these extra .rodata characters should save us a nice little amount of binary size.
This patch was created by running
find src/ -type f -exec perl -0777 -pi -e 's/printk(\s*BIOS_ERR,\s*"ERROR: /printk(BIOS_ERR, "/gi' '{}' ';'
and doing some cursory review/cleanup on the result. Then doing the same thing for BIOS_WARN with
's/printk(\s*BIOS_WARNING,\s*"WARN(ING)?: /printk(BIOS_WARNING, "/gi'
Signed-off-by: Julius Werner jwerner@chromium.org Change-Id: I3d0573acb23d2df53db6813cb1a5fc31b5357db8 --- M src/acpi/acpigen.c M src/arch/arm64/fit_payload.c M src/arch/x86/acpi_bert_storage.c M src/arch/x86/tables.c M src/commonlib/storage/sd_mmc.h M src/cpu/x86/mtrr/mtrr.c M src/cpu/x86/smm/tseg_region.c M src/device/dram/ddr4.c M src/device/dram/lpddr4.c M src/device/oprom/realmode/x86.c M src/device/pci_device.c M src/device/pnp_device.c M src/drivers/analogix/anx7625/anx7625.c M src/drivers/i2c/max98390/max98390.c M src/drivers/i2c/tpm/cr50.c M src/drivers/intel/fsp1_1/fsp_relocate.c M src/drivers/intel/fsp2_0/memory_init.c M src/drivers/intel/pmc_mux/conn/conn.c M src/drivers/net/atl1e.c M src/drivers/net/r8168.c M src/drivers/pc80/rtc/option.c M src/drivers/spi/tpm/tpm.c M src/drivers/ti/sn65dsi86bridge/sn65dsi86bridge.c M src/drivers/vpd/vpd.c M src/drivers/wifi/generic/acpi.c M src/ec/google/chromeec/ec.c M src/lib/bootmem.c M src/lib/cbfs.c M src/lib/cbmem_stage_cache.c M src/lib/edid.c M src/lib/fit.c M src/lib/fit_payload.c M src/lib/fmap.c M src/lib/thread.c M src/lib/timestamp.c M src/mainboard/google/gru/mainboard.c M src/mainboard/google/kahlee/OemCustomize.c M src/mainboard/google/kahlee/variants/baseboard/memory.c M src/mainboard/google/octopus/romstage.c M src/mainboard/intel/harcuvar/romstage.c M src/mainboard/scaleway/tagada/romstage.c M src/northbridge/amd/agesa/family14/northbridge.c M src/northbridge/intel/gm45/raminit.c M src/northbridge/intel/i945/gma.c M src/northbridge/intel/sandybridge/common.c M src/security/tpm/tss/tcg-2.0/tss_marshaling.c M src/soc/amd/cezanne/data_fabric.c M src/soc/amd/cezanne/i2c.c M src/soc/amd/cezanne/root_complex.c M src/soc/amd/cezanne/smihandler.c M src/soc/amd/common/block/acpi/bert.c M src/soc/amd/common/block/acpi/gpio.c M src/soc/amd/common/block/apob/apob_cache.c M src/soc/amd/common/block/cpu/mca/mca_bert.c M src/soc/amd/common/block/cpu/mca/mcax_bert.c M src/soc/amd/common/block/cpu/noncar/memmap.c M src/soc/amd/common/block/cpu/smm/smm_helper.c M src/soc/amd/common/block/gpio/gpio.c M src/soc/amd/common/block/lpc/espi_util.c M src/soc/amd/common/block/lpc/spi_dma.c M src/soc/amd/common/block/pci/amd_pci_util.c M src/soc/amd/common/block/pm/pmlib.c M src/soc/amd/common/block/smu/smu.c M src/soc/amd/common/fsp/dmi.c M src/soc/amd/common/fsp/fsp_reset.c M src/soc/amd/common/fsp/pci/pci_routing_info.c M src/soc/amd/common/pi/agesawrapper.c M src/soc/amd/common/pi/def_callouts.c M src/soc/amd/common/pi/s3_resume.c M src/soc/amd/common/psp_verstage/psp_verstage.c M src/soc/amd/common/psp_verstage/vboot_crypto.c M src/soc/amd/common/vboot/vboot_bootblock.c M src/soc/amd/picasso/data_fabric.c M src/soc/amd/picasso/i2c.c M src/soc/amd/picasso/root_complex.c M src/soc/amd/picasso/smihandler.c M src/soc/amd/stoneyridge/romstage.c M src/soc/cavium/cn81xx/cpu.c M src/soc/cavium/cn81xx/ecam0.c M src/soc/intel/alderlake/chip.c M src/soc/intel/alderlake/romstage/fsp_params.c M src/soc/intel/alderlake/systemagent.c M src/soc/intel/alderlake/vr_config.c M src/soc/intel/braswell/southcluster.c M src/soc/intel/broadwell/pch/me_status.c M src/soc/intel/cannonlake/chip.c M src/soc/intel/cannonlake/vr_config.c M src/soc/intel/common/block/acpi/acpi_bert.c M src/soc/intel/common/block/cse/cse.c M src/soc/intel/common/block/cse/cse_eop.c M src/soc/intel/common/block/fast_spi/fast_spi_flash.c M src/soc/intel/common/block/irq/irq.c M src/soc/intel/common/block/pcie/pcie_helpers.c M src/soc/intel/common/block/pmc/pmclib.c M src/soc/intel/common/block/thermal/thermal_pci.c M src/soc/intel/quark/storage_test.c M src/soc/intel/skylake/vr_config.c M src/soc/intel/tigerlake/chip.c M src/soc/mediatek/common/include/soc/msdc.h M src/soc/mediatek/mt8173/da9212.c M src/soc/mediatek/mt8173/mt6311.c M src/soc/mediatek/mt8195/dpm_4ch.c M src/soc/mediatek/mt8195/dptx.c M src/soc/mediatek/mt8195/dptx_hal.c M src/soc/mediatek/mt8195/mt6691.c M src/soc/nvidia/tegra/usb.c M src/soc/nvidia/tegra210/dp.c M src/soc/nvidia/tegra210/dsi.c M src/soc/nvidia/tegra210/funitcfg.c M src/soc/qualcomm/common/clock.c M src/soc/qualcomm/common/usb/qmpv3_usb_phy.c M src/soc/qualcomm/common/usb/qmpv4_usb_phy.c M src/soc/qualcomm/common/usb/qusb_phy.c M src/soc/rockchip/common/rk808.c M src/soc/rockchip/rk3288/crypto.c M src/soc/rockchip/rk3399/display.c M src/soc/ti/am335x/mmc.c M src/southbridge/amd/common/amd_pci_util.c M src/southbridge/intel/bd82x6x/early_me.c M src/southbridge/intel/bd82x6x/early_me_mrc.c M src/southbridge/intel/common/spi.c M src/southbridge/intel/lynxpoint/early_me.c M src/superio/nuvoton/nct5104d/superio.c M src/superio/smsc/lpc47n217/superio.c M src/superio/smsc/lpc47n227/superio.c M src/superio/smsc/sch5545/superio.c M src/vendorcode/eltan/security/verified_boot/vboot_check.c M src/vendorcode/google/chromeos/cr50_enable_update.c M src/vendorcode/google/chromeos/sar.c 129 files changed, 306 insertions(+), 330 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/61309/13