Attention is currently required from: Shelley Chen.
Nick Vaccaro has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79854?usp=email )
Change subject: mb/google/brox: Set up FW_CONFIG ......................................................................
Patch Set 1:
(2 comments)
File src/mainboard/google/brox/variants/brox/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/79854/comment/0e46292a_ecfdc4bb : PS1, Line 8: option STORAGE_UFS 0 If you think emmc might be added later, might be better to make this field STORAGE 2 3 option STORAGE_UNKNOWN 0 option STORAGE_UFS 1 option STORAGE_NVME 2
https://review.coreboot.org/c/coreboot/+/79854/comment/b4994f70_637ed23f : PS1, Line 11: end 1) It will likely need a field for WiFi Device (not sure if kernel will need a field for WLAN type and/or WLAN interface), I guess it could have a lookup table to get device and then determine what the WLAN type is from there, might want to ask kernel folks what they want / need).
2) add field for AUDIO_CODEC (right now, only 1 will be defined, but that list will likely grow)
3) maybe add field for USB_SENSOR to indicate camera used