Dtrain Hsu has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/44056 )
Change subject: mb/google/dedede/var/madoo: Add discrete WiFi configuration ......................................................................
mb/google/dedede/var/madoo: Add discrete WiFi configuration
Add RTL8822CE support for Madoo.
BUG=b:162390420 BRANCH=None TEST=FW_NAME=madoo emerge-dedede coreboot chromeos-bootimage, build successful
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I6e471be2b2856977e6f728d5a2ca78942725bea6 --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 7 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/56/44056/1
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index 3f99927..6937338 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -91,7 +91,13 @@ end end # I2C 2 device pci 15.3 off end # I2C 3 - device pci 1c.7 on end + device pci 1c.7 on + chip drivers/wifi/generic + register "wake" = "GPE0_DW2_03" + register "maxsleep" = "3" + device pci 00.0 on end + end + end # PCI Express Root Port 8 - WLAN device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44056 )
Change subject: mb/google/dedede/var/madoo: Add discrete WiFi configuration ......................................................................
Patch Set 1: Code-Review+2
EricR Lai has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44056 )
Change subject: mb/google/dedede/var/madoo: Add discrete WiFi configuration ......................................................................
Patch Set 1: Code-Review+1
Justin TerAvest has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44056 )
Change subject: mb/google/dedede/var/madoo: Add discrete WiFi configuration ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/44056 )
Change subject: mb/google/dedede/var/madoo: Add discrete WiFi configuration ......................................................................
mb/google/dedede/var/madoo: Add discrete WiFi configuration
Add RTL8822CE support for Madoo.
BUG=b:162390420 BRANCH=None TEST=FW_NAME=madoo emerge-dedede coreboot chromeos-bootimage, build successful
Signed-off-by: Dtrain Hsu dtrain_hsu@compal.corp-partner.google.com Change-Id: I6e471be2b2856977e6f728d5a2ca78942725bea6 Reviewed-on: https://review.coreboot.org/c/coreboot/+/44056 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Karthik Ramasubramanian kramasub@google.com Reviewed-by: EricR Lai ericr_lai@compal.corp-partner.google.com Reviewed-by: Justin TerAvest teravest@chromium.org --- M src/mainboard/google/dedede/variants/madoo/overridetree.cb 1 file changed, 7 insertions(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Justin TerAvest: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved EricR Lai: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/dedede/variants/madoo/overridetree.cb b/src/mainboard/google/dedede/variants/madoo/overridetree.cb index 3f99927..6937338 100644 --- a/src/mainboard/google/dedede/variants/madoo/overridetree.cb +++ b/src/mainboard/google/dedede/variants/madoo/overridetree.cb @@ -91,7 +91,13 @@ end end # I2C 2 device pci 15.3 off end # I2C 3 - device pci 1c.7 on end + device pci 1c.7 on + chip drivers/wifi/generic + register "wake" = "GPE0_DW2_03" + register "maxsleep" = "3" + device pci 00.0 on end + end + end # PCI Express Root Port 8 - WLAN device pci 19.0 on chip drivers/i2c/generic register "hid" = ""10EC5682""
-
Dtrain Hsu (Code Review) -
EricR Lai (Code Review)
-
Justin TerAvest (Code Review)
-
Karthik Ramasubramanian (Code Review)
-
Patrick Georgi (Code Review)