Christoph Grenz (christophg+cb@grenz-bonn.de) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/3495
-gerrit
commit da5f76b57622a8cf984e0423ac7b3ca48160e21b Author: Christoph Grenz christophg+cb@grenz-bonn.de Date: Tue Jun 18 01:26:50 2013 +0200
w83627hf: Fix address alignment error in superio.asl and add comments about parallel port modes.
The resource template for the parallel port contained 0x0FFC as maximum acceptable I/O starting address for EPP mode. EPP mode needs 8 bit alignment, so 0x0FF8 is correct.
Change-Id: If4e224dbaf6f9105cde88d995d2e7c74fbf14502 Signed-off-by: Christoph Grenz christophg+cb@grenz-bonn.de --- src/superio/winbond/w83627hf/acpi/superio.asl | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/superio/winbond/w83627hf/acpi/superio.asl b/src/superio/winbond/w83627hf/acpi/superio.asl index 69017fe..67cf67a 100644 --- a/src/superio/winbond/w83627hf/acpi/superio.asl +++ b/src/superio/winbond/w83627hf/acpi/superio.asl @@ -529,6 +529,7 @@ Device(SIO) {
Name (_PRS, ResourceTemplate () { + /* Traditional configurations (SPP mode) */ StartDependentFn (0,1) { IO (Decode16, 0x0378, 0x0378, 0x04, 0x08) @@ -544,6 +545,7 @@ Device(SIO) { IO (Decode16, 0x03BC, 0x03BC, 0x04, 0x04) IRQNoFlags () {3,4,5,7,9,10,11,12} } + /* Traditional configurations (EPP mode) */ StartDependentFn (0,0) { IO (Decode16, 0x0378, 0x0378, 0x08, 0x08) @@ -554,11 +556,13 @@ Device(SIO) { IO (Decode16, 0x0278, 0x0278, 0x08, 0x08) IRQNoFlags () {3,4,5,7,9,10,11,12} } + /* Any configurable address (EPP mode) */ StartDependentFn (2,0) { - IO (Decode16, 0x0100, 0x0FFC, 0x08, 0x08) + IO (Decode16, 0x0100, 0x0FF8, 0x08, 0x08) IRQNoFlags () {3,4,5,7,9,10,11,12} } + /* Any configurable address (No EPP mode) */ StartDependentFn (2,1) { IO (Decode16, 0x0100, 0x0FFC, 0x04, 0x08)