Attention is currently required from: Andrey Pronin, Christian Walter, Yi Chou.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71885 )
Change subject: security/tpm/tss/tcg-2.0: Add `tlcl_read_public()`
......................................................................
Patch Set 2:
(2 comments)
File src/security/tpm/tss/tcg-2.0/tss.c:
https://review.coreboot.org/c/coreboot/+/71885/comment/d1b45bb0_f67a4313
PS2, Line 504: /* Unknown handle, returned if the key doesn't exist. */
Is this comment for which switch case?
File src/security/tpm/tss/tcg-2.0/tss_marshaling.c:
https://review.coreboot.org/c/coreboot/+/71885/comment/1a5ca069_577993ef
PS2, Line 550: "%s:%d - "
: "size mismatch: expected %d, remaining %zd\n",
Can fit in one line.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71885
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I79455b3ee73c265a9e4bf3d8b9c6562490efbf1c
Gerrit-Change-Number: 71885
Gerrit-PatchSet: 2
Gerrit-Owner: Yi Chou
yich@google.com
Gerrit-Reviewer: Andrey Pronin
apronin@google.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Andrey Pronin
apronin@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Yi Chou
yich@google.com
Gerrit-Comment-Date: Thu, 02 Feb 2023 08:56:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment