Change in coreboot[master]: mb/mainboard/herobrine: Initialize SPI FW for EC and TPM - coreboot-gerrit

4 Nov 2021


      Attention is currently required from: Ravi kumar, Paul Menzel, mturney mturney, Rajesh Patil.
Shelley Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50581 )
Change subject: mb/mainboard/herobrine: Initialize SPI FW for EC and TPM
......................................................................
Patch Set 84:
(1 comment)
File src/mainboard/google/herobrine/Kconfig:
https://review.coreboot.org/c/coreboot/+/50581/comment/fc1d9518_32547f69 
PS84, Line 66: 	default 0xC if BOARD_GOOGLE_HEROBRINE
I think that this should never be true?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/50581
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8cbdd1d59a0166688d52d61646db1b6764879a7c
Gerrit-Change-Number: 50581
Gerrit-PatchSet: 84
Gerrit-Owner: Ravi kumar rbokka@codeaurora.org
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Shelley Chen shchen@google.com
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Reviewer: mturney mturney mturney@codeaurora.org
Gerrit-CC: Mukesh Savaliya msavaliy@qualcomm.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-CC: Rajesh Patil rajpat@qualcomm.corp-partner.google.com
Gerrit-CC: Ravi Kumar Bokka c_rbokka@qualcomm.corp-partner.google.com
Gerrit-Attention: Ravi kumar rbokka@codeaurora.org
Gerrit-Attention: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Rajesh Patil rajpat@qualcomm.corp-partner.google.com
Gerrit-Comment-Date: Thu, 04 Nov 2021 01:04:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment