Duncan Laurie has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31277
Change subject: x86/acpi: Use PM_TABLET where appropriate ......................................................................
x86/acpi: Use PM_TABLET where appropriate
Instead of having SYSTEM_TYPE_DETACHABLE and SYSTEM_TYPE_TABLET use PM_MOBILE have them use PM_TABLET instead.
Change-Id: If0ce51e522d36420ecd5b51bdfec6cca11c00333 Signed-off-by: Duncan Laurie dlaurie@google.com --- M src/arch/x86/acpi.c 1 file changed, 4 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/77/31277/1
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index a89b871..0c85d3a 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -1067,10 +1067,11 @@ fadt->x_dsdt_h = 0;
if (IS_ENABLED(CONFIG_SYSTEM_TYPE_CONVERTIBLE) || - IS_ENABLED(CONFIG_SYSTEM_TYPE_DETACHABLE) || - IS_ENABLED(CONFIG_SYSTEM_TYPE_LAPTOP) || - IS_ENABLED(CONFIG_SYSTEM_TYPE_TABLET)) + IS_ENABLED(CONFIG_SYSTEM_TYPE_LAPTOP)) fadt->preferred_pm_profile = PM_MOBILE; + else if (IS_ENABLED(CONFIG_SYSTEM_TYPE_DETACHABLE) || + IS_ENABLED(CONFIG_SYSTEM_TYPE_TABLET)) + fadt->preferred_pm_profile = PM_TABLET; else fadt->preferred_pm_profile = PM_DESKTOP;
HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31277 )
Change subject: x86/acpi: Use PM_TABLET where appropriate ......................................................................
Patch Set 1: Code-Review+1
Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31277 )
Change subject: x86/acpi: Use PM_TABLET where appropriate ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31277 )
Change subject: x86/acpi: Use PM_TABLET where appropriate ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31277 )
Change subject: x86/acpi: Use PM_TABLET where appropriate ......................................................................
x86/acpi: Use PM_TABLET where appropriate
Instead of having SYSTEM_TYPE_DETACHABLE and SYSTEM_TYPE_TABLET use PM_MOBILE have them use PM_TABLET instead.
Change-Id: If0ce51e522d36420ecd5b51bdfec6cca11c00333 Signed-off-by: Duncan Laurie dlaurie@google.com Reviewed-on: https://review.coreboot.org/c/31277 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Furquan Shaikh furquan@google.com Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/arch/x86/acpi.c 1 file changed, 4 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved Furquan Shaikh: Looks good to me, approved HAOUAS Elyes: Looks good to me, but someone else must approve
diff --git a/src/arch/x86/acpi.c b/src/arch/x86/acpi.c index a89b871..0c85d3a 100644 --- a/src/arch/x86/acpi.c +++ b/src/arch/x86/acpi.c @@ -1067,10 +1067,11 @@ fadt->x_dsdt_h = 0;
if (IS_ENABLED(CONFIG_SYSTEM_TYPE_CONVERTIBLE) || - IS_ENABLED(CONFIG_SYSTEM_TYPE_DETACHABLE) || - IS_ENABLED(CONFIG_SYSTEM_TYPE_LAPTOP) || - IS_ENABLED(CONFIG_SYSTEM_TYPE_TABLET)) + IS_ENABLED(CONFIG_SYSTEM_TYPE_LAPTOP)) fadt->preferred_pm_profile = PM_MOBILE; + else if (IS_ENABLED(CONFIG_SYSTEM_TYPE_DETACHABLE) || + IS_ENABLED(CONFIG_SYSTEM_TYPE_TABLET)) + fadt->preferred_pm_profile = PM_TABLET; else fadt->preferred_pm_profile = PM_DESKTOP;
-
Duncan Laurie (Code Review) -
Furquan Shaikh (Code Review)
-
HAOUAS Elyes (Code Review)
-
Patrick Georgi (Code Review)